geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donal Evans <doev...@pivotal.io>
Subject Re: [VOTE] Fix bad-merge of GEODE-7488
Date Fri, 22 Nov 2019 20:29:33 GMT
+1

While I'm against overriding PR checks in general, this is clearly a
special case.

On Fri, Nov 22, 2019 at 12:10 PM Nabarun Nag <nnag@apache.org> wrote:

> +1
>
> On Fri, Nov 22, 2019 at 12:00 PM Anthony Baker <abaker@pivotal.io> wrote:
>
> > Clearly the right thing to do is fix it.  VOTE not needed IMO.
> >
> > Anthony
> >
> >
> > > On Nov 22, 2019, at 11:55 AM, Robert Houghton <rhoughton@pivotal.io>
> > wrote:
> > >
> > > I was overzealous in a merge to Geode, and got us into a
> chicken-and-egg
> > > issue for PRs and reverts. Calling a vote to override the GitHub merge
> > > button restriction via commiter privileges, to merge the fix in
> > > https://github.com/apache/geode/pull/4360
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message