From dev-return-32281-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Oct 30 01:21:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C4FA91804BB for ; Wed, 30 Oct 2019 02:20:59 +0100 (CET) Received: (qmail 97285 invoked by uid 500); 30 Oct 2019 01:20:59 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 97219 invoked by uid 99); 30 Oct 2019 01:20:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2019 01:20:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ECDF0C1CFA for ; Wed, 30 Oct 2019 01:20:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.499 X-Spam-Level: X-Spam-Status: No, score=-0.499 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=0.2, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 7dcoxVhZoBxn for ; Wed, 30 Oct 2019 01:20:56 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.153.148; helo=mx0b-00296801.pphosted.com; envelope-from=dschneider@pivotal.io; receiver= Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id B6A167F5C0 for ; Wed, 30 Oct 2019 01:10:51 +0000 (UTC) Received: from pps.filterd (m0114586.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9U1AoOX019885 for ; Wed, 30 Oct 2019 01:10:50 GMT Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by mx0b-00296801.pphosted.com with ESMTP id 2vxwerg5av-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 30 Oct 2019 01:10:50 +0000 Received: by mail-il1-f199.google.com with SMTP id w69so691606ilk.2 for ; Tue, 29 Oct 2019 18:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kXxpUMWvejfQmUWmU8KQ4itzwHsdICinQzXo3N/lfjo=; b=ooVGwLV7ZrHkbuCZRL3sngutHpXLH3300f7nkvyEF9DmYnw6DD8yn1XLCa1gQRQxZg 9qaEDzhrelGrdnrsjzsA0oD1hcpFQHntZ3NO15ZVif64eqihxoeqwg5yL6/w2FTG3iXa /0ljFMOFNIsvXLyWl/R+zPc117weiY4gOEZKxhIAPmEG9WcmL+UT6niLxbvrqO44O0oL RxfVT2+E0bW7p3tcYWyG4yb9nGTYhjwAi1fUW/Ops63QagWDn1a0cjuajQWuQe50waAW GV6DdPz0xHc7ZB/vKfKMQ5VwjA3XjOiktjiDz6OcaL0cNV213r3nPP2fjd3DoHyi0BIE tYTA== X-Gm-Message-State: APjAAAU83creBEo2ouumMsEL7+szejkxeQ3ggAzqCxCQB+mzNe6QpeX0 u/17ORZhxW+eEdBu8cNSWrXM1lsRACdGQENuh0ozEWwQrh2+zL6D5YhTMjXzBIpHYVb2vlv6V89 P4fpFg8k7iJnZZbIeFl9TqCNIwmQIqE7az8u7xFjfTiJajQ7hoz5C9vs= X-Received: by 2002:a92:d3cb:: with SMTP id c11mr11606027ilh.74.1572397849334; Tue, 29 Oct 2019 18:10:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjevKGI9eExrc+blnXGVfCS6Ce8TjlZf42eg2jbgQ/Nz4h5mBXUIjEbhYqgeVqMmmGwek3FpCwLqzTrBDk7os= X-Received: by 2002:a92:d3cb:: with SMTP id c11mr11606007ilh.74.1572397849123; Tue, 29 Oct 2019 18:10:49 -0700 (PDT) MIME-Version: 1.0 References: <0E741094-FC81-4D51-B9CC-BCE1634792F0@pivotal.io> In-Reply-To: <0E741094-FC81-4D51-B9CC-BCE1634792F0@pivotal.io> From: Darrel Schneider Date: Tue, 29 Oct 2019 18:10:38 -0700 Message-ID: Subject: Re: [DISCUSS] Tweak to branch protection rules To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="0000000000003e3914059616679c" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-30_01:2019-10-28,2019-10-30 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=3 phishscore=0 mlxlogscore=887 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910300011 --0000000000003e3914059616679c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable +1 On Tue, Oct 29, 2019 at 6:08 PM Owen Nichols wrote: > +1 =E2=80=A6this has already bitten me a few times > > > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote: > > > > Hi all, > > > > It seems we've configured our branch protection rules such that pushing= a > > change to a PR that has been approved invalidates the previous approval= . > > > > I think we should turn this off - it looks like it's an optional featur= e. > > We should trust people to rerequest reviews if needed. Right now this i= s > > adding busywork for people to reapprove minor changes (Fixing merge > > conflicts, spotless, etc.) > > > > If you all agree I'll ask infra to uncheck "Dismiss stale pull request > > approvals when new commits are pushed." in our branch protection rules. > > > > -Dan > > --0000000000003e3914059616679c--