From dev-return-32143-archive-asf-public=cust-asf.ponee.io@geode.apache.org Tue Oct 8 14:54:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5F4DC180654 for ; Tue, 8 Oct 2019 16:54:30 +0200 (CEST) Received: (qmail 1944 invoked by uid 500); 8 Oct 2019 14:54:29 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 1928 invoked by uid 99); 8 Oct 2019 14:54:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Oct 2019 14:54:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A7737C22A0 for ; Tue, 8 Oct 2019 14:54:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.301 X-Spam-Level: * X-Spam-Status: No, score=1.301 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id aOqe_1iu27GC for ; Tue, 8 Oct 2019 14:54:26 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.153.148; helo=mx0b-00296801.pphosted.com; envelope-from=jramos@pivotal.io; receiver= Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 09FC27E1C3 for ; Tue, 8 Oct 2019 14:54:25 +0000 (UTC) Received: from pps.filterd (m0114586.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x98ElRiv028939 for ; Tue, 8 Oct 2019 14:54:24 GMT Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by mx0b-00296801.pphosted.com with ESMTP id 2vg2vp18cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 08 Oct 2019 14:54:24 +0000 Received: by mail-ed1-f69.google.com with SMTP id 38so11393381edr.4 for ; Tue, 08 Oct 2019 07:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=u5DR2z4ddm1Mni6v1At2wcQxbB1QIaCG5nA1vQoga1M=; b=DR7f9yG1AqzqVXd41ojeuSBWu5DRDYN41+dkBXEwDABwadSZ93vJeWE7aG8iqynuXj FyJDFd4K6mnHYvUl6km0i3QlAuGbpVmhF6+E5YJeFn1dEOtFk/gw/OR8hN/GRgRgSGvF mKCypWzh5KfR0jLqjCNbhSjTXK0b/AxWFJKB0ScGb32wbvEkqwE9A5ReF9lx0/EnIm90 6BoScG8dI3yi4W8IHXhZ1KHcR2/o59JfhrSbWTrMLAyO3wxd/csKQc5+aV0jRA9sjkrw NVear3R07qwvtPnwk6NI+i26+I+GklRaNw0kiEN1YAvP3ZV6bf2OpjtbjKkdjyD84BsR kMAQ== X-Gm-Message-State: APjAAAXQ+GaS2TJXRUT9CJh/ulUq4zt+5KbuNPQriJgaFu4Z3P33iPd9 +de4w/ZFYr+tJEtZhBq36GfG7Rmnhrpm1fhFfsKHGz0QCzrmyqcXBqzwdwyk6Vgs01HMrbJSBMH ckQ6tRf8SoaWvu6Ra1MPrggsP6CNmE8425HhXwxf1O4t5c4j4HQUwTdA= X-Received: by 2002:aa7:d48f:: with SMTP id b15mr34369029edr.159.1570546462224; Tue, 08 Oct 2019 07:54:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyezbAnNGSCyfS/HN+S1/8YW1PjWE6l1vfr8ukk//kRUPMB6f0KfXFwgo4DcNrxapNaMGCLdXSXpsdv9fyI9I= X-Received: by 2002:aa7:d48f:: with SMTP id b15mr34369010edr.159.1570546461936; Tue, 08 Oct 2019 07:54:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Juan_Jos=C3=A9_Ramos?= Date: Tue, 8 Oct 2019 15:54:10 +0100 Message-ID: Subject: Re: [DISCUSS]: Commit Message Format too Short? To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="000000000000f7b01505946757a3" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-08_05:2019-10-08,2019-10-08 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 clxscore=1015 phishscore=0 malwarescore=0 mlxscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910080134 --000000000000f7b01505946757a3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Alberto, It might help to add the reminder to the PR template but, honestly, I don't think many people is actually paying much attention to that... in fact I recall another email thread from some time ago discussing getting rid of the template altogether :-/. Cheers. On Tue, Oct 8, 2019 at 11:58 AM Alberto Bustamante Reyes wrote: > I think its a good idea to have an automatic mechanism to reject commits > that exceed a given limit. > In the previous project I was assigned we used Gerrit instead of Github, > and we had an automatic check to vote -1 if your commit message exceeded > the limit. > > Anyway, while this is decided, a quick action could be to add a new line > to the PR template, at least to remember it: > > - [ ] Is your commit message length below the limit of 50 characters? > > > > > > ________________________________ > De: Juan Jos=C3=A9 Ramos > Enviado: martes, 8 de octubre de 2019 11:32 > Para: dev@geode.apache.org > Asunto: Re: [DISCUSS]: Commit Message Format too Short? > > Hello Owen, > > Yes, I fully agree with you. And just to be clear, I wasn't trying to > discourage descriptive commit messages, on the contrary, we certainly mus= t > encourage them at all cost!!. It was decided that we should, however, try > to keep consistency across all commits and make the subject brief, adding > the full details within the body of the text; as described in *How to wri= te > a Git commit message [1], *referenced in our *Commit Message Format > [2] *article. > Right now we're not enforcing this rule, there are even some commits > without the ticket number at the beginning of the commit subject :-/. > I guess the goal of this thread is to gather some feedback and opinions > from the community to better decide how to proceed: remove the rule, > increase the maximum amount of characters from 50 to something else in th= e > commit message subject, automatically enforce the rule altogether and > prevent commits that don't follow it, etc. > Best regards. > > [1]: https://chris.beams.io/posts/git-commit/ > [2]: > https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format > > On Tue, Oct 8, 2019 at 10:07 AM Owen Nichols wrote: > > > I don=E2=80=99t care how long it is, but knowing that many tools show o= nly the > > first bit, it=E2=80=99s helpful if the message is phrased with the most= important > > words near the beginning. > > > > I=E2=80=99d much prefer to encourage rather than discourage descriptive= commit > > messages. Even better if all commit messages mentioned more about _why_ > the > > change is being made, not just describe the diff. > > > > But most important of all, NEVER forget the colon between the ticket > number > > and the rest. I learned that the hard way :( > > > > -Owen > > > > On Tue, Oct 8, 2019 at 1:52 AM Ju@N wrote: > > > > > Hello devs, > > > > > > I've notice that, lately, not everybody is following the guidelines w= e > > have > > > highlighted in our Wiki under *Commit Message Format [1]*, specially > the > > > first requirement: *GEODE-nn: Capitalized, 50 chars or less summary. > *As > > an > > > example, out of the last 33 commits in develop, only 11 follow the 50 > > chars > > > max rule. > > > Even though I've always followed this "rule", I often find it hard to > > > provide a summary of the commit in less than 50 chars, that's probabl= y > > the > > > reason why other people are just ignoring this part of the guidelines= ?. > > > Should we increase the maximum amount of characters from 50 to > something > > > else?, should we add a hard check in order to automatically enforce t= he > > > rule?, should we delete the rule altogether?, thoughts?. > > > Best regards. > > > > > > [1]: > > > > https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format > > > > > > -- > > > Ju@N > > > > > > > > -- > Juan Jos=C3=A9 Ramos Cassella > Senior Software Engineer > Email: jramos@pivotal.io > --=20 Juan Jos=C3=A9 Ramos Cassella Senior Software Engineer Email: jramos@pivotal.io --000000000000f7b01505946757a3--