geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Owen Nichols <onich...@pivotal.io>
Subject Re: [DISCUSS] Blocking merge button in PR
Date Mon, 21 Oct 2019 17:37:02 GMT
I *really* like the idea of requiring all PR checks to have *completed* before merge.  Does
anyone know if this GitHub offers a knob for this?

> On Oct 21, 2019, at 4:53 AM, Ju@N <jujoramos@gmail.com> wrote:
> 
> +10 to Naba's proposal, it seems the right thing to do and will help us to
> prevent accidentally breaking *develop* while keeping focus on people
> instead of processes.
> I'd add, however, that the *Merge Pull Request* button should remain
> disabled until *all CIs have finished*, and only enable it once the *Build,
> Unit, Stress Tests and LGTM are green *(that is, force the committer to
> wait at least until all CIs are done)*. *I also agree in that that we
> should require *at least one* official approval.
> Cheers.


Mime
View raw message