geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Schuchardt <bschucha...@pivotal.io>
Subject Re: Lingering Geode 1.10.0 release issues
Date Fri, 27 Sep 2019 17:44:58 GMT
Unfortunately I'm finding that our gradle build scripts are also using 
string comparisons on Geode versions.  You can't do something like

     (oldGeodeVersion >= "1.7.0")

and expect that to work when the version is "1.10.0"

On 9/27/19 10:12 AM, Bruce Schuchardt wrote:
> Some backward-compatibility tests are using string comparisons on 
> versions, which isn't working well with our new "1.10.0".  Others are 
> converting version strings into numbers, so 1.10.0 becomes 1100.  
> That's working okay but is also a time-bomb.  I'm changing the tests 
> to use a new TestVersion class that knows how to work with 
> major.minor.patch strings.
>
> On 9/27/19 9:28 AM, Dan Smith wrote:
>> Bruce has picked up GEODE-7250.
>>
>> -Dan
>>
>> On Fri, Sep 27, 2019 at 9:27 AM Dick Cavender <dcavender@pivotal.io> 
>> wrote:
>>
>>> If you try and brew update to Geode 1.10.0 you won't get it until our
>>> 1.10.0 homebrew PR 
>>> <https://github.com/Homebrew/homebrew-core/pull/44586>
>>> gets
>>> through their checks and their Jenkins servers seem to be having 
>>> problems
>>> this week so this is still in flight.
>>>
>>> On geode develop I've had to revert the "add 1.10.0 to old versions" 
>>> post
>>> release change because it was causing tests to fail. Until new JIRA
>>> GEODE-7250 is fixed we will not be testing 1.10.0 as an old version. 
>>> This
>>> JIRA needs to be prioritized and the PR with the fix needs to 
>>> include the
>>> revert changes to get 1.10.0 back in the old versions.
>>>
>>> Let me know if anyone has questions on these.
>>>
>>> -Dick
>>>

Mime
View raw message