geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@apache.org>
Subject Re: [VOTE] Apache Geode 1.9.1.RC3
Date Thu, 05 Sep 2019 17:16:05 GMT
Note to anyone actually trying to build and run unit tests using the
*rel/v1.9.1.RC3* tag...

1.9.x does not contain my fix for PartitionedRegionLoadModelJUnitTest so it
may fail as it depends on your networking configuration.

The failure looks like:








*org.apache.geode.internal.cache.partitioned.rebalance.PartitionedRegionLoadModelJUnitTest
> testRedundancySatisfactionPreferRemoteIp FAILED
java.lang.AssertionError:
expected:<[Create[member=10.118.33.202(5346)<ec>:3,bucketId=0],
Create[member=10.118.33.202(5346)<ec>:3,bucketId=1],
Create[member=10.118.33.202(5346)<ec>:3,bucketId=2]]> but
was:<[Create[member=10.118.33.202(5346)<ec>:3,bucketId=0],
Create[member=10.118.33.202(5346)<ec>:1,bucketId=1],
Create[member=10.118.33.202(5346)<ec>:3,bucketId=2]]>        at
org.junit.Assert.fail(Assert.java:88)        at
org.junit.Assert.failNotEquals(Assert.java:834)        at
org.junit.Assert.assertEquals(Assert.java:118)        at
org.junit.Assert.assertEquals(Assert.java:144)        at
org.apache.geode.internal.cache.partitioned.rebalance.PartitionedRegionLoadModelJUnitTest.testRedundancySatisfactionPreferRemoteIp(PartitionedRegionLoadModelJUnitTest.java:224)*

The fix (in develop and 1.10.x) is in this commit:






*commit 81e52443445fef3745f4249c1eb08e1a19f7392eAuthor: Kirk Lund
<klund@apache.org <klund@apache.org>>Date:   Thu Apr 11 16:20:50 2019
-0700    GEODE-6618: Remove PartitionedRegionLoadModelJUnitTest etc hosts
dependency (#3435)*

I simply changed the test to use *SocketCreator.getLocalHost()* instead of
*InetAddress.getLocalHost()*. A better fix would be to add a bit more
abstraction to tests being tested so that the test doesn't use LocalHost.
Unit tests shouldn't depend on networking or host configuration.

So, if you are testing 1.9.1 by building and unit testing the source test,
please be aware that you may see PartitionedRegionLoadModelJUnitTest fail
depending on your networking configuration.


On Thu, Sep 5, 2019 at 9:27 AM Kirk Lund <klund@apache.org> wrote:

> +1 to release RC3. Downloaded and reviewed contents of artifacts. Reviewed
> Manifest of geode dependency jar. Used GFSH to start locator and server.
>
> On Wed, Sep 4, 2019 at 11:50 AM Dave Barnes <dbarnes@pivotal.io> wrote:
>
>> +1
>> checked the geode-native package by successfully building the library and
>> the api docs.
>>
>> On Wed, Sep 4, 2019 at 11:26 AM Jens Deppe <jdeppe@pivotal.io> wrote:
>>
>> > No, It's fixed in 1.10.x.
>> >
>> > On Wed, Sep 4, 2019 at 10:16 AM Robert Houghton <rhoughton@pivotal.io>
>> > wrote:
>> >
>> > > Hi Jens,
>> > >
>> > > Does this issue appear in 1.10.0.RC1?
>> > >
>> > > On Tue, Sep 3, 2019, 13:03 Jens Deppe <jdeppe@pivotal.io> wrote:
>> > >
>> > > > TL;DR: +0
>> > > >
>> > > > When using gfsh over http, the following exception occurs:
>> > > >
>> > > > (1) Executing - connect --url=https://localhost:7070/geode-mgmt/v1
>> > > >
>> > > >
>> > >
>> >
>> --security-properties-file=/Users/jdeppe/workspace/gemfire-develop/open/security.properties
>> > > > <
>> > >
>> >
>> https://localhost:7070/geode-mgmt/v1--security-properties-file=/Users/jdeppe/workspace/gemfire-develop/open/security.properties
>> > > >
>> > > >
>> > > > Exception in thread "main" java.lang.NoClassDefFoundError:
>> > > > org/apache/geode/management/internal/web/shell/HttpOperationInvoker
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.commands.ConnectCommand.httpConnect(ConnectCommand.java:284)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.commands.ConnectCommand.connect(ConnectCommand.java:153)
>> > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> > > > at java.lang.reflect.Method.invoke(Method.java:498)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.remote.CommandExecutor.callInvokeMethod(CommandExecutor.java:111)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.remote.CommandExecutor.invokeCommand(CommandExecutor.java:121)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.remote.CommandExecutor.execute(CommandExecutor.java:63)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.remote.CommandExecutor.execute(CommandExecutor.java:57)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.shell.GfshExecutionStrategy.execute(GfshExecutionStrategy.java:84)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.springframework.shell.core.AbstractShell.executeCommand(AbstractShell.java:134)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.shell.Gfsh.executeCommand(Gfsh.java:584)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.springframework.shell.core.AbstractShell.executeScriptLine(AbstractShell.java:74)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.shell.Gfsh.executeScriptLine(Gfsh.java:615)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.Launcher.parseOptions(Launcher.java:232)
>> > > > at
>> > > >
>> > > >
>> > >
>> >
>> org.apache.geode.management.internal.cli.Launcher.parseCommandLine(Launcher.java:250)
>> > > > at
>> > > >
>> >
>> org.apache.geode.management.internal.cli.Launcher.main(Launcher.java:135)
>> > > > Caused by: java.lang.ClassNotFoundException:
>> > > > org.apache.geode.management.internal.web.shell.HttpOperationInvoker
>> > > > at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
>> > > > at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>> > > > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
>> > > > at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>> > > > ... 19 more
>> > > >
>> > > > The problem is that the geode-web.jar is not included in
>> > > > gfsh-dependencies.jar as part of the build.
>> > > >
>> > > > Since this issue appears to also exist on 1.9.0 I'm going to +0
>> > (instead
>> > > of
>> > > > -1). Others may feel differently. A workaround exists simply by
>> adding
>> > > the
>> > > > missing jar when running gfsh.
>> > > >
>> > > > --Jens
>> > > >
>> > > > On Tue, Sep 3, 2019 at 10:45 AM John Blum <jblum@pivotal.io>
wrote:
>> > > >
>> > > > > 1 more thing...
>> > > > >
>> > > > > I would additionally advise rewording the sentence...
>> > > > >
>> > > > > *> Please add log4j-core to the classpath.*
>> > > > >
>> > > > > To read...
>> > > > >
>> > > > > "*Please consider adding log4j-core, or another Logging provider
>> > (e.g.
>> > > > > Logback), to your classpath.  Apache Geode works best with
>> Log4j.*"
>> > > > >
>> > > > > Food for thought.
>> > > > >
>> > > > > -John
>> > > > >
>> > > > >
>> > > > > On Tue, Sep 3, 2019 at 10:40 AM John Blum <jblum@pivotal.io>
>> wrote:
>> > > > >
>> > > > > > +1
>> > > > > >
>> > > > > > Ran SDG build against Apache Geode 1.9.1 build snapshots
(for
>> RC3).
>> > > > > >
>> > > > > > However, can we seriously reconsider logging the follow
message
>> at
>> > > > ERROR?
>> > > > > > Ugh!
>> > > > > >
>> > > > > > ERROR StatusLogger Log4j2 could not find a logging
>> implementation.
>> > > > Please
>> > > > > > add log4j-core to the classpath. Using SimpleLogger to log
to
>> the
>> > > > > console...
>> > > > > >
>> > > > > > WARN is more than sufficient.  If no logging provider is
on the
>> > > > > CLASSPATH,
>> > > > > > it creates a lot of noise!
>> > > > > >
>> > > > > > -John
>> > > > > >
>> > > > > >
>> > > > > > On Fri, Aug 30, 2019 at 12:27 PM Dave Barnes <
>> dbarnes@pivotal.io>
>> > > > wrote:
>> > > > > >
>> > > > > >> +1
>> > > > > >> Checked the docs: Successfully built viewed the Geode
User
>> Guide
>> > and
>> > > > the
>> > > > > >> Javadocs.
>> > > > > >>
>> > > > > >> On Fri, Aug 30, 2019 at 11:11 AM Owen Nichols <
>> > onichols@pivotal.io>
>> > > > > >> wrote:
>> > > > > >>
>> > > > > >> > Hello Geode dev community,
>> > > > > >> >
>> > > > > >> > This is a release candidate for Apache Geode, version
>> 1.9.1.RC3.
>> > > > > >> > Thanks to all the community members for their contributions
>> to
>> > > this
>> > > > > >> > release!
>> > > > > >> >
>> > > > > >> > Please do a review and give your feedback. The
deadline is
>> 3PM
>> > PST
>> > > > > Thu,
>> > > > > >> > September 05 2019.
>> > > > > >> > Release notes can be found at:
>> > > > > >> >
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.9.1
>> > > > > >> >
>> > > > > >> > Please note that we are voting upon the source
tags:
>> > > rel/v1.9.1.RC3
>> > > > > >> >
>> > > > > >> > Apache Geode:
>> > > > > >> > https://github.com/apache/geode/tree/rel/v1.9.1.RC3
>> > > > > >> > Apache Geode examples:
>> > > > > >> > https://github.com/apache/geode-examples/tree/rel/v1.9.1.RC3
>> > > > > >> > Apache Geode native:
>> > > > > >> > https://github.com/apache/geode-native/tree/rel/v1.9.1.RC3
>> > > > > >> >
>> > > > > >> > Source and binary files:
>> > > > > >> > https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC3/
>> > > > > >> >
>> > > > > >> > Maven staging repo:
>> > > > > >> >
>> > > > >
>> > https://repository.apache.org/content/repositories/orgapachegeode-1057
>> > > > > >> >
>> > > > > >> > Geode's KEYS file containing PGP keys we use to
sign the
>> > release:
>> > > > > >> > https://github.com/apache/geode/blob/develop/KEYS
>> > > > > >> >
>> > > > > >> > PS: Command to run geode-examples: ./gradlew
>> -PgeodeReleaseUrl=
>> > > > > >> > https://dist.apache.org/repos/dist/dev/geode/1.9.1.RC3
>> > > > > >> > -PgeodeRepositoryUrl=
>> > > > > >> >
>> > > > >
>> > https://repository.apache.org/content/repositories/orgapachegeode-1057
>> > > > > >> > build runAll
>> > > > > >> >
>> > > > > >> > Regards
>> > > > > >> > Owen & Kirk
>> > > > > >> >
>> > > > > >> >
>> > > > > >>
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > -John
>> > > > > > john.blum10101 (skype)
>> > > > > >
>> > > > >
>> > > > >
>> > > > > --
>> > > > > -John
>> > > > > john.blum10101 (skype)
>> > > > >
>> > > >
>> > >
>> >
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message