From dev-return-31587-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Aug 14 20:14:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D5661802C7 for ; Wed, 14 Aug 2019 22:14:00 +0200 (CEST) Received: (qmail 34855 invoked by uid 500); 14 Aug 2019 20:14:00 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 34821 invoked by uid 99); 14 Aug 2019 20:14:00 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Aug 2019 20:14:00 +0000 Received: from Udos-MacBook-Pro.local (50-203-225-134-static.hfc.comcastbusiness.net [50.203.225.134]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id EBBAF852D for ; Wed, 14 Aug 2019 20:13:59 +0000 (UTC) Subject: Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize() To: dev@geode.apache.org References: <1132191B-F151-4114-867B-5568810570DB@pivotal.io> <9CF08C70-17F4-4595-895F-3BF6F3252599@pivotal.io> From: Udo Kohlmeyer Message-ID: Date: Wed, 14 Aug 2019 13:13:59 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Thunderbird/69.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US @Aaron,Kirk - thank you for the clarification. +1 to include the fix, as reverting GEODE-7001 would be more effort :) --Udo On 8/14/19 9:25 AM, Aaron Lindsey wrote: > @Udo, I think Kirk explained it well — This issue was introduced very recently (right before we cut the release branch) and it has serious consequences (requires restarting the server). > > - Aaron > >> On Aug 14, 2019, at 9:06 AM, Kirk Lund wrote: >> >> +1 to include this fix in 1.10.0 >> >> FYI: The race condition for this code path to throw NPE (which is >> catastrophic and requires restarting the server) was introduced by commit >> 279fa0 on July 31 for GEODE-7001. >> >> On Tue, Aug 13, 2019 at 6:22 PM Anthony Baker wrote: >> >>> Given that we’re trying to stabilize the release branch and this fix seems >>> to *help* that I’m in favor of merging it. >>> >>> Anthony >>> >>> >>>> On Aug 13, 2019, at 5:32 PM, Udo Kohlmeyer wrote: >>>> >>>> @Aaron, is this an existing issue (i.e this was not introduced in a >>> current refactor)? >>>> If the answer is anything other that "This will make the system stop >>> working", I would vote: -1 >>>> If this is an existing issue and has been around for a while, I think we >>> hold off including this. >>>> I think the boat has sailed on the inclusion of issues into the 1.10 >>> release. Sorry... >>>> --Udo >>>> >>>> On 8/13/19 4:58 PM, Aaron Lindsey wrote: >>>>> I’d like to propose including >>> https://github.com/apache/geode/pull/3913/commits/6f1814d1f719cc06b13769c40a9d6d01f99f927c >>> < >>> https://github.com/apache/geode/pull/3913/commits/6f1814d1f719cc06b13769c40a9d6d01f99f927c> >>> in the Geode 1.10 release. >>>>> This commit fixes an issue where a NullPointerException is thrown from >>> PartitionedRegion.getLocalSize() when the statistics callback sampler is >>> invoked before a PartitionedRegion is initialized. >>>>> - Aaron >>>>> >>>>> >>>>> >>>