From dev-return-31557-archive-asf-public=cust-asf.ponee.io@geode.apache.org Tue Aug 13 16:59:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2AFC01804BB for ; Tue, 13 Aug 2019 18:59:26 +0200 (CEST) Received: (qmail 18147 invoked by uid 500); 13 Aug 2019 16:59:25 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 18136 invoked by uid 99); 13 Aug 2019 16:59:25 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Aug 2019 16:59:25 +0000 Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 4412684E5 for ; Tue, 13 Aug 2019 16:59:25 +0000 (UTC) Received: by mail-ot1-f70.google.com with SMTP id q16so16588677ota.20 for ; Tue, 13 Aug 2019 09:59:25 -0700 (PDT) X-Gm-Message-State: APjAAAXHn8AcHweGkpkIBnsLMSFwIMPApUUUlVGBWc/SJ6v7LP2i/RRR 4Xd4y7k+QtocfPnzVj8IBa9B0bnabQrwCe9/xrhOko5tMof3QHi4shDt4Z1uWVAXdkUQgLnaPJi 9NRK8gpQqdjypqrF4tluGlVamKTqBimWT/enYRXY6yr4auRTr7nTmeGw= X-Received: by 2002:a9d:675a:: with SMTP id w26mr7915075otm.179.1565715564597; Tue, 13 Aug 2019 09:59:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmvnXbGMM3Ltm7ZELapXwkgYvcmx0ixM/pAdL+VjWQ8pVBKZtLJ//P0LixFdqdADxY8WGFZY4dy0lyuYBiClo= X-Received: by 2002:a9d:675a:: with SMTP id w26mr7915070otm.179.1565715564495; Tue, 13 Aug 2019 09:59:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kirk Lund Date: Tue, 13 Aug 2019 09:59:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Fix for NPE during forceDisconnect candidate for 1.10.0 To: geode Content-Type: multipart/alternative; boundary="0000000000000a9a6d05900290e8" --0000000000000a9a6d05900290e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I guess we need at least one more vote to get this fix copied to the 1.10.0 release branch. We just confirmed that this fix is NOT on that branch yet. On Thu, Aug 8, 2019 at 11:03 AM Juan Jos=C3=A9 Ramos wr= ote: > +1 > > On Thu, Aug 8, 2019 at 7:02 PM John Blum wrote: > > > +1 for Kirk's changes in 1.10. This will be critical for SD Neuman and > > SBDG 1.3. > > > > On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols > wrote: > > > > > Hi Kirk and Mark, thank you for bringing your concern. > > > > > > Our =E2=80=9Ccritical fixes=E2=80=9D rule allows critical fixes to be= brought to the > > > release branch by proposal on the dev list, as you have just done. I= f > > > there is consensus from the Geode community that this NPE fix satisfi= es > > the > > > =E2=80=9Ccritical fixes=E2=80=9D rule, Dick or I will be happy to bri= ng it to the > 1.10.0 > > > release branch. > > > > > > -Owen > > > > > > > On Aug 8, 2019, at 10:54 AM, Kirk Lund wrote: > > > > > > > > I'd like to propose including the fix for GEODE-6959 in 1.10.0. > > > > > > > > Spring Boot users are very likely to hit this NPE during > > forceDisconnect. > > > > > > > > If a custom log4j2.xml is used without specifying the Geode > > > AlertAppender, > > > > GMSMembershipManager may throw a NullPointerException when invoking > > > > AlertAppender.getInstance().stopSession() during a forceDisconnect. > > This > > > > change prevents the NullPointerException allowing forceDisconnect t= o > > > finish. > > > > Tests are included with this fix. > > > > > > > > PR: https://github.com/apache/geode/pull/3899 > > > > GEODE-6959: NPE if AlertAppender is not defined > > > > > > > > Thanks, > > > > Kirk and Mark > > > > > > > > > > -- > > -John > > john.blum10101 (skype) > > > > > -- > Juan Jos=C3=A9 Ramos Cassella > Senior Technical Support Engineer > Email: jramos@pivotal.io > Office#: +353 21 4238611 > Mobile#: +353 87 2074066 > After Hours Contact#: +1 877 477 2269 > Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - 16:00 GMT > How to upload artifacts: > https://support.pivotal.io/hc/en-us/articles/204369073 > How to escalate a ticket: > https://support.pivotal.io/hc/en-us/articles/203809556 > > [image: support] [image: twitter] > [image: linkedin] > [image: facebook] > [image: google plus] > [image: youtube] > > --0000000000000a9a6d05900290e8--