From dev-return-31610-archive-asf-public=cust-asf.ponee.io@geode.apache.org Thu Aug 15 22:21:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F5E2180645 for ; Fri, 16 Aug 2019 00:21:12 +0200 (CEST) Received: (qmail 33139 invoked by uid 500); 15 Aug 2019 22:21:12 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 33128 invoked by uid 99); 15 Aug 2019 22:21:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Aug 2019 22:21:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 481F91A324F for ; Thu, 15 Aug 2019 22:21:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.301 X-Spam-Level: * X-Spam-Status: No, score=1.301 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vcot-yf7JoWe for ; Thu, 15 Aug 2019 22:21:09 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.153.148; helo=mx0b-00296801.pphosted.com; envelope-from=dsmith@pivotal.io; receiver= Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 66F897DC05 for ; Thu, 15 Aug 2019 22:21:07 +0000 (UTC) Received: from pps.filterd (m0114586.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7FML6vo023661 for ; Thu, 15 Aug 2019 22:21:06 GMT Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0b-00296801.pphosted.com with ESMTP id 2ubf81k6qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 15 Aug 2019 22:21:06 +0000 Received: by mail-ua1-f70.google.com with SMTP id l2so509516uan.21 for ; Thu, 15 Aug 2019 15:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=T+mACtP2S42TZ60mqpU2vnzO6hy98JMDKhp6mINeXVY=; b=P5jL0yWyA+M2PMplRtnpaxssYIuL4MBA58VX9sSYMdkWlKj5UbA08Zy2xUH5XN5ucn OXTFA9yLleMKWyM11ImpX8NRdb1RVfgnTHPuLLhfXRRjxF4ucMJLA5n8mPujB+MUGjbb 8SYsF7fhcoEmmS0pg0ZT5FO/v5pVxc5qUvfdNf/F4hZFqlz2mrQjPR+GNkqgwVxa5f0W P0+AVpTW4SYXhYI12Xv/dVFouY2V2dj8JjPqp6r6JT7JhPnnOqqd8dLticajaapOB97V djT9vsiPI2d8aM/GE717EvBim6SukqS7b0xjEEu/2bLYKo29O4LJEmet4WZ9Q9kGEk2n 4LCw== X-Gm-Message-State: APjAAAWIYVIFPhOrx2TuTZZsGPEe4rUuV3+85HQonQY1WbFcKjKrUNZP z4iQ53K//3mBAqwY3WpQRWsOQgTP3tuKD7MITooWqWZXOt63hD+5T6N1exPSnWwwRUpDHuuDR9i xNzvQrjuUKwVFrZGiEblt0kyaV5tqp3ATIvWBtsCnmysS8VX3+u68csU= X-Received: by 2002:ab0:28c:: with SMTP id 12mr4678306uah.118.1565907665435; Thu, 15 Aug 2019 15:21:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMGbPKQb9upiU1auzQL2tFCwdHwY+nIybziwyDOKMDDUmOYsk5mWYsi9hYdvvO+izunSAT6tWZEXliopep1cM= X-Received: by 2002:ab0:28c:: with SMTP id 12mr4678300uah.118.1565907665088; Thu, 15 Aug 2019 15:21:05 -0700 (PDT) MIME-Version: 1.0 References: <1132191B-F151-4114-867B-5568810570DB@pivotal.io> <9CF08C70-17F4-4595-895F-3BF6F3252599@pivotal.io> <44516767-F293-41A6-9389-91570B33294E@pivotal.io> In-Reply-To: From: Dan Smith Date: Thu, 15 Aug 2019 15:20:54 -0700 Message-ID: Subject: Re: Propose fix for 1.10 release: Prevent NPE in getLocalSize() To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="00000000000021051105902f4a3c" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-15_10:2019-08-14,2019-08-15 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908150211 --00000000000021051105902f4a3c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable @kirk - go ahead and push it. -Dan On Thu, Aug 15, 2019 at 3:13 PM Kirk Lund wrote: > I have the cherry-pick ready to push or file a PR. Let me know what you > prefer... > > On Thu, Aug 15, 2019 at 3:01 PM Dan Smith wrote: > > > Normally cherry-picking to the release branch is the release managers j= ob > > (Dick in this case) [1]. He asked me to help out while he was on > vacation, > > so I will go ahead and cherry-pick it over. > > > > I kinda like the process Jake proposed though - creating a PR against t= he > > release branch. My only concern would be that maybe it would be too eas= y > > for someone to accidentally merge to the release branch without realizi= ng > > that was the target? Still might be better than making the release > manager > > do the cherry-pick. > > > > [1] > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geod= e > > > > -Dan > > > > On Thu, Aug 15, 2019 at 2:53 PM Jacob Barrett > wrote: > > > > > You should be able to do the cherry-pick on your fork and then open a > PR > > > against the release branch. > > > > > > > On Aug 15, 2019, at 2:04 PM, Aaron Lindsey > > wrote: > > > > > > > > It sounds like there is consensus on adding this fix. Could someone > > > please cherry-pick this for me? > > > > > > > > Thanks, > > > > Aaron > > > > > > > >> On Aug 14, 2019, at 1:13 PM, Udo Kohlmeyer wrote: > > > >> > > > >> @Aaron,Kirk - thank you for the clarification. > > > >> > > > >> +1 to include the fix, as reverting GEODE-7001 would be more effor= t > :) > > > >> > > > >> --Udo > > > >> > > > >> On 8/14/19 9:25 AM, Aaron Lindsey wrote: > > > >>> @Udo, I think Kirk explained it well =E2=80=94 This issue was int= roduced > very > > > recently (right before we cut the release branch) and it has serious > > > consequences (requires restarting the server). > > > >>> > > > >>> - Aaron > > > >>> > > > >>>> On Aug 14, 2019, at 9:06 AM, Kirk Lund wrote: > > > >>>> > > > >>>> +1 to include this fix in 1.10.0 > > > >>>> > > > >>>> FYI: The race condition for this code path to throw NPE (which i= s > > > >>>> catastrophic and requires restarting the server) was introduced = by > > > commit > > > >>>> 279fa0 on July 31 for GEODE-7001. > > > >>>> > > > >>>> On Tue, Aug 13, 2019 at 6:22 PM Anthony Baker > > > wrote: > > > >>>> > > > >>>>> Given that we=E2=80=99re trying to stabilize the release branch= and this > > fix > > > seems > > > >>>>> to *help* that I=E2=80=99m in favor of merging it. > > > >>>>> > > > >>>>> Anthony > > > >>>>> > > > >>>>> > > > >>>>>> On Aug 13, 2019, at 5:32 PM, Udo Kohlmeyer > > wrote: > > > >>>>>> > > > >>>>>> @Aaron, is this an existing issue (i.e this was not introduced > in > > a > > > >>>>> current refactor)? > > > >>>>>> If the answer is anything other that "This will make the syste= m > > stop > > > >>>>> working", I would vote: -1 > > > >>>>>> If this is an existing issue and has been around for a while, = I > > > think we > > > >>>>> hold off including this. > > > >>>>>> I think the boat has sailed on the inclusion of issues into th= e > > 1.10 > > > >>>>> release. Sorry... > > > >>>>>> --Udo > > > >>>>>> > > > >>>>>> On 8/13/19 4:58 PM, Aaron Lindsey wrote: > > > >>>>>>> I=E2=80=99d like to propose including > > > >>>>> > > > > > > https://github.com/apache/geode/pull/3913/commits/6f1814d1f719cc06b13769c= 40a9d6d01f99f927c > > > >>>>> < > > > >>>>> > > > > > > https://github.com/apache/geode/pull/3913/commits/6f1814d1f719cc06b13769c= 40a9d6d01f99f927c > > > > > > > >>>>> in the Geode 1.10 release. > > > >>>>>>> This commit fixes an issue where a NullPointerException is > thrown > > > from > > > >>>>> PartitionedRegion.getLocalSize() when the statistics callback > > > sampler is > > > >>>>> invoked before a PartitionedRegion is initialized. > > > >>>>>>> - Aaron > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>> > > > > > > > > > > > > > --00000000000021051105902f4a3c--