geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Blum <jb...@pivotal.io>
Subject Re: Fix for NPE during forceDisconnect candidate for 1.10.0
Date Thu, 08 Aug 2019 18:02:11 GMT
+1 for Kirk's changes in 1.10.  This will be critical for SD Neuman and
SBDG 1.3.

On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols <onichols@pivotal.io> wrote:

> Hi Kirk and Mark, thank you for bringing your concern.
>
> Our “critical fixes” rule allows critical fixes to be brought to the
> release branch by proposal on the dev list, as you have just done.  If
> there is consensus from the Geode community that this NPE fix satisfies the
> “critical fixes” rule, Dick or I will be happy to bring it to the 1.10.0
> release branch.
>
> -Owen
>
> > On Aug 8, 2019, at 10:54 AM, Kirk Lund <klund@apache.org> wrote:
> >
> > I'd like to propose including the fix for GEODE-6959 in 1.10.0.
> >
> > Spring Boot users are very likely to hit this NPE during forceDisconnect.
> >
> > If a custom log4j2.xml is used without specifying the Geode
> AlertAppender,
> > GMSMembershipManager may throw a NullPointerException when invoking
> > AlertAppender.getInstance().stopSession() during a forceDisconnect. This
> > change prevents the NullPointerException allowing forceDisconnect to
> finish.
> > Tests are included with this fix.
> >
> > PR: https://github.com/apache/geode/pull/3899
> > GEODE-6959: NPE if AlertAppender is not defined
> >
> > Thanks,
> > Kirk and Mark
>
>

-- 
-John
john.blum10101 (skype)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message