geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Lindsey <alind...@pivotal.io>
Subject Re: New release branch for Apache Geode 1.10.0
Date Sat, 03 Aug 2019 00:24:57 GMT
+1 to including this PR in the 1.10.0 release.

Just to elaborate on the issue: If the stats sampler calls LocalRegion.getLocalSize before
that region is initialized, it will throw a NullPointerException. This can happen because
we have escaping references to “this” in the LocalRegion constructor that allow the stats
sampler to call getLocalSize before the LocalRegion object is fully constructed.

- Aaron

> On Aug 2, 2019, at 5:21 PM, Michael Oleske <moleske@pivotal.io> wrote:
> 
> Naba's concern was this PR: https://github.com/apache/geode/pull/3880 which
> has been merged to develop
> 
> -michael
> 
> On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols <onichols@pivotal.io> wrote:
> 
>> Hi Naba, thank you for bringing your concern.
>> 
>> Our current process <
>> https://lists.apache.org/thread.html/d36a63c3794d13506ecad3d52a2aca938dcf0f8509b61860bbbc50cd@%3Cdev.geode.apache.org%3E>
>> dictates a time-based schedule to cut release branches.  Once cut, the
>> “critical fixes” rule allows critical fixes to be brought to the release
>> branch by proposal on the dev list.
>> 
>> Currently the 1.10.0 release pipeline <
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-10-0-main>
>> is all green.  Perhaps one way to convince the Geode community that your
>> fix satisfies the “critical fixes” rule might be to share a link to a
>> github commit adding tests that expose the issue.
>> 
>> Thanks,
>> -Owen
>> 
>> 
>>> On Aug 2, 2019, at 12:55 PM, Nabarun Nag <nnag@apache.org> wrote:
>>> 
>>> Hi,
>>> 
>>> We believe that the current release branch has an issue of getting a
>>> NullPointerException when we try calling LocalRegion.getLocalSize when
>> the
>>> region is in the process of being initialized. The fix for this issue is
>>> very critical and we should re-create the branch when the fix is placed
>> in
>>> develop.
>>> We need to hold any pipeline testing on the branch till this fix is in.
>>> 
>>> Regards
>>> Nabarun Nag
>>> 
>>> On Fri, Aug 2, 2019 at 11:17 AM Dick Cavender <dixie@apache.org> wrote:
>>> 
>>>> Hello Geode Dev Community,
>>>> 
>>>> We have created a new release branch for Apache Geode 1.10.0 -
>>>> "release/1.10.0"
>>>> 
>>>> Please do review and raise any concern with the release branch. If no
>>>> concerns are raised, we will start with the voting for the release
>>>> candidate soon.
>>>> 
>>>> Regards
>>>> 
>>>> Dick Cavender
>>>> Apache Geode 1.10.0 Release Manager
>>>> 
>> 
>> 


Mime
View raw message