geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Barrett <jbarr...@pivotal.io>
Subject Re: Problem with LGTM on geode-native pull request
Date Wed, 31 Jul 2019 21:46:10 GMT
I would say for this PR, back out the LGTM changes and just move forward ignoring the LGTM
results.

> On Jul 31, 2019, at 12:14 PM, Blake Bender <bbender@pivotal.io> wrote:
> 
> Still looking into this, don’t expect to have a resolution today
> necessarily.  I turned off network support in our build of Xerces, since we
> don’t use it, and that got rid of some, but not all, of the unresolved
> references.  I’ll have to get hold of the LGTM Docker image to see what’s
> going on with the rest of the issues.  I’m 100% convinced it’s not an issue
> with this PR, though - develop branch has the same problem.
> 
> Thanks,
> 
> Blake
> 
> 
> On Wed, Jul 31, 2019 at 7:08 AM Blake Bender <bbender@pivotal.io> wrote:
> 
>> Linking errors look like (perhaps among other things) missing symbols for
>> libcurl(?) needed by the Xerces library, which was recently added.  We
>> build internally against RHEL 7, Ubuntu, Windows, and develop on MacBook
>> Pros, but it appears LGTM is attempting to build on some other OS flavor
>> and maybe missing some dependencies.  I'll investigate this morning.
>> 
>> Thanks,
>> 
>> Blake
>> 
>> 
>> On Wed, Jul 31, 2019 at 5:38 AM Alberto Gomez <alberto.gomez@est.tech>
>> wrote:
>> 
>>> Hi,
>>> 
>>> I updated the .lgtm.yml file so that the right version of Apache Geode
>>> is downloaded and now I get errors in the linking process about some
>>> symbols not found.
>>> 
>>> Could anybody help with this?
>>> 
>>> Thanks,
>>> 
>>> Alberto
>>> 
>>> On 30/7/19 15:50, Jacob Barrett wrote:
>>>> Yes, that seems to be the issue. Can you update the lgtm.yml and push
>>> to your branch.
>>>> 
>>>> Thanks,
>>>> Jake
>>>> 
>>>> 
>>>>> On Jul 30, 2019, at 5:09 AM, Alberto Gomez <alberto.gomez@est.tech>
>>> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> I am getting a failure on the C/C++ LGTM analysis over a recently
>>>>> created pull request on geode-native:
>>>>> https://github.com/apache/geode-native/pull/504
>>>>> 
>>>>> I have noticed that this it the first PR on geode-native having LGTM
>>>>> analysis.
>>>>> 
>>>>> There is a .lgtm.yml on the repo that does not seem up to date as it
>>>>> references Apache 1.7.0. This could be the source of the problem.
>>>>> 
>>>>> Any ideas?
>>>>> 
>>>>> Thanks in advance,
>>>>> 
>>>>> -Alberto G.
>>>>> 
>>> 
>> 


Mime
View raw message