From dev-return-31156-archive-asf-public=cust-asf.ponee.io@geode.apache.org Fri May 31 20:48:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A1669180627 for ; Fri, 31 May 2019 22:48:24 +0200 (CEST) Received: (qmail 95227 invoked by uid 500); 31 May 2019 20:48:24 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 95211 invoked by uid 99); 31 May 2019 20:48:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2019 20:48:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D0DE180F73 for ; Fri, 31 May 2019 20:48:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.698 X-Spam-Level: X-Spam-Status: No, score=-0.698 tagged_above=-999 required=6.31 tests=[MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rlUMgZJETQwK for ; Fri, 31 May 2019 20:48:20 +0000 (UTC) Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 955ED5F27B for ; Fri, 31 May 2019 20:48:20 +0000 (UTC) Received: from pps.filterd (m0114585.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4VKkNxX032550 for ; Fri, 31 May 2019 20:48:20 GMT Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0b-00296801.pphosted.com with ESMTP id 2su8enr6j3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 31 May 2019 20:48:20 +0000 Received: by mail-pg1-f199.google.com with SMTP id d7so5478002pgc.8 for ; Fri, 31 May 2019 13:48:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version:date :subject:message-id:references:in-reply-to:to; bh=WXMHGTvHL7VvVwoaYiuIJYAkl7FR6O71W4hyY96zQ0E=; b=aQj06X4TkOFg1j98VeJB5dxhMD1LYWi933zrOrm1qewjIjTrKrfAA8dX2obqLNFnZ8 TpbOMyNrgDrziiTKzcC5TGn0k6ULUK10DbvYow/4MVTd1bEJbJGfht5SK2coIZZ+NsjX vzbecnakjfNoVTqz/wtFxtSIeOprHoSO1qOjYD+UssOpwEKRbTk0RoglSq/swGy6V3TB AF2O6sjzFiBUe88ASWF++0HepDErXP8tgzcn5Oypc5eG2U+mu6VkFYEcqB4+fgCfIvcS l25KkDnBXYO34mxbCPlsfYzcgbPJIM2a6ZkHr7hhlpQ9sK0RN8sM5G7S+Tm/BWBxLEfC BkcQ== X-Gm-Message-State: APjAAAUYKnI5EJ89VYync2f5E9zabsUDLc9LJXAA6gFiMxM0N6UK9aSq TJY3L6cQT3M0vM0SPbvSgO94O+AT+rsRSKA8f7dPGGEYoM22o17LEVGQRUrWFwZ2HK6egfkQODv T4H493csRgIWZ60WOSmVVTZmqLubOM1PdN1hXBM8= X-Received: by 2002:a62:1b85:: with SMTP id b127mr12583185pfb.165.1559335698887; Fri, 31 May 2019 13:48:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4vKtXpwMbmQZc2a4j+o82XVjfdqGwRJhvL9tCeZfF5KI2anf/wAVyZlAh37Z8v+hFK3jydw== X-Received: by 2002:a62:1b85:: with SMTP id b127mr12583164pfb.165.1559335698608; Fri, 31 May 2019 13:48:18 -0700 (PDT) Received: from ?IPv6:2600:2100:7:8000:cc25:f61:a90:522d? ([2600:2100:7:8000:cc25:f61:a90:522d]) by smtp.gmail.com with ESMTPSA id e12sm9839569pfl.122.2019.05.31.13.48.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 13:48:18 -0700 (PDT) From: Jacob Barrett Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Date: Fri, 31 May 2019 13:48:17 -0700 Subject: Re: [DISCUSS] require reviews before merging a PR Message-Id: <9B32F675-EDB3-4FF0-99B3-43BC1F92F18B@pivotal.io> References: <1A10BB0D-15D5-4C99-B064-3502B239CBA0@pivotal.io> <41897d27-8135-44ae-a799-f570aeb0e9e2@pivotal.io> <93BB7236-656C-431F-9A10-2B31626E43EE@pivotal.io> In-Reply-To: To: dev@geode.apache.org X-Mailer: iPhone Mail (16F156) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-31_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=688 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905310126 It is probably worthwhile to codify our =E2=80=9Cpolicy=E2=80=9D so that it=E2= =80=99s not confused later. Simply adding something about lazy consensus mod= el to the CONTRIBUTING.md (which I realize we are missing, already working o= n that) might be useful. I could take a stab at the wording based on my earlier reply about this if n= o one else wants to. -jake > On May 31, 2019, at 12:44 PM, Owen Nichols wrote: >=20 > I have learned that other than the required quarterly report to the board,= just about everything else about being an Apache project is just guidelines= , not hard requirements. I was confused because we do adhere rigorously to e= very other voting guideline on https://www.apache.org/foundation/voting.html= ; now I understand that is by choice and not because Apache =E2=80=9Crequire= s=E2=80=9D it. =20 >=20 > Thank you for all the responses on this thread. It seems like the consens= us is that we=E2=80=99ve struck an appropriate balance already (and in parti= cular regard to reviews, that we can trust committers to seek an appropriate= amount of review based on the nature and scope of a PR). >=20 > I will not seek a vote on enforcing a requirement of 1 (or more) reviews b= efore a PR can be merged, since some valid scenarios were raised where 0 rev= iews prior to merge could be appropriate. >=20 >> On May 31, 2019, at 9:01 AM, Jacob Barrett wrote: >>=20 >>=20 >>> On May 31, 2019, at 8:52 AM, Owen Nichols wrote: >>>=20 >>> Apache requires 3 reviews for code changes. Docs and typos likely would n= ot >>> fall under that heading. >>=20 >> Where is this listed as a requirement? The link you sent before offered g= uidance on common policies within the organization. >>=20 >=20