geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Baker <aba...@pivotal.io>
Subject Re: [DISCUSS] require reviews before merging a PR
Date Fri, 31 May 2019 16:44:05 GMT
When asking a question like “What is ASF policy and practice on XXX?” I have found that
observing other ASF projects can be helpful.  In particular, the ASF Incubator (general@incubator.apache.org
<mailto:general@incubator.apache.org>) covers these topics fairly frequently.

Anthony


> On May 31, 2019, at 9:05 AM, Alexander Murmann <amurmann@pivotal.io> wrote:
> 
> Jake, Owen is quoting the "VOTES ON CODE MODIFICATION" section from
> https://www.apache.org/foundation/voting.html . "code modification" ==
> "every PR" is a interpretation that I think would bring the project to a
> grinding halt.
> 
> On Fri, May 31, 2019 at 9:01 AM Jacob Barrett <jbarrett@pivotal.io> wrote:
> 
>> 
>> 
>>> On May 31, 2019, at 8:52 AM, Owen Nichols <onichols@pivotal.io> wrote:
>>> 
>>> Apache requires 3 reviews for code changes. Docs and typos likely would
>> not
>>> fall under that heading.
>> 
>> Where is this listed  as a requirement? The link you sent before offered
>> guidance on common policies within the organization.
>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message