geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <>
Subject what is the best way to update a geode pull request
Date Fri, 31 May 2019 20:20:00 GMT
Something I have noticed is that often when I have requested changes be
made to a pull request is that the changes are force pushed ask a single
commit to the pr. I would actually prefer that the changes show up as a new
commit on the pr instead of everything being rebased into one commit. That
makes the history of the pr easier to follow and make it easy to see what
has changed since the previous review. What do others think? Have we done
something that makes contributors think the pull request has to be single
commit? I know the initial pull request is supposed to be but from then on
I'd prefer that we wait to squash when we merge it to develop.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message