geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Smith <dsm...@pivotal.io>
Subject Re: [DISCUSS] Remove exception.getMessage() error handling
Date Fri, 24 May 2019 22:37:55 GMT
I think the right thing to do in those 100+ cases may be different in each
case, a blanket search and replace might not be the best idea.

-Dan



On Fri, May 24, 2019 at 3:05 PM Jinmei Liao <jiliao@pivotal.io> wrote:

> does exception.toString() print out the entire stack trace? If so, I don't
> think we should use that to replace exception.getMessage().
>
> On Fri, May 24, 2019 at 1:18 PM Jack Weissburg <jweissburg@pivotal.io>
> wrote:
>
> > Hi All,
> >
> > Owen and I investigated a strange error message caused because Geode
> > previously handled an error exception with exception.getMessage() instead
> > of
> >  exception.toString().
> >
> > The issue is that the exception message from exception.getMessage() could
> > be unhelpful or empty. Instead, we should return the whole exception via
> > exception.toString().
> >
> > exception.getMessage()is used widely throughout the Geode code base (100+
> > times) and could be prone to cause more issues similar to
> > https://issues.apache.org/jira/browse/GEODE-6796
> > I would like to change the remaining instances of
> exception.getMessage()to
> > avoid future issues of this variety.
> >
> > Thoughts? Comments?
> >
> > Best,
> > Jack Weissburg
> >
>
>
> --
> Cheers
>
> Jinmei
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message