geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Blake Bender <bben...@pivotal.io>
Subject Re: [DISCUSS] is it time to make Windows tests gating?
Date Thu, 16 May 2019 22:06:23 GMT
+1 this needs to happen.  I hope that doesn't cause too much pain for the
dev team, but the native client team has a hard requirement that all our
stuff works properly on Windows at all times, and it can cause trouble if
random builds of the server can break us on Windows.

I would hesitate to run these per-commit if they're taking that long, but
daily is a thing that can easily happen.

On Thu, May 16, 2019 at 2:23 PM Bruce Schuchardt <bschuchardt@pivotal.io>
wrote:

> big +1, as long as artifacts of failed runs can be downloaded
>
> On 5/15/19 6:28 PM, Owen Nichols wrote:
> > For a very long time we’ve had Windows tests in the main pipeline
> (hidden away, not in the default view), but the pipeline proceeds to
> publish regardless of whether Windows tests fail or even run at all.
> >
> > Now seems like a good time to review whether to:
> > a) treat Windows tests as first-class tests and prevent the pipeline
> from proceeding if any test fails on Windows
> > b) keep as-is
> > c) change Windows tests to trigger only once a week rather than on every
> commit, if they are going to remain "informational only"
> >
> > One disadvantage to making Windows tests gating is that they currently
> take much longer to run (around 5 hours, vs 2 hours for Linux tests).
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message