geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <...@apache.org>
Subject Re: [DISCUSS] Move or remove org.apache.geode.admin
Date Wed, 03 Apr 2019 00:12:30 GMT
+1 on removing the JMXManager stuff for Geode 2.0 release.

But this "hidden" feature, what is that? Is this something that we would 
like to support or is this something that would be replaced with our 
existing efforts in the ConfigurationService and Metrics area.

On 4/2/19 17:04, Dan Smith wrote:
> Hi devs,
>
> The org.apache.geode.admin package has been deprecated for about 7 years
> [1].
>
> I'd like to remove it, or at least move it to a separate module. I actually
> started some work to move it to a separate module [2]. However in the
> course of this process, I've found that this module has extremely little
> test coverage, so I'm not confident in the move. For example, it has a
> whole JMX manager feature (different than our current JMX manager) which
> does not appear to have any tests. This JMX manager feature won't work as
> shipped unless you find and add some mx4j jars to your classpath.
>
> I think the best course of action is probably to remove it entirely.
> However, this does bring up a couple of questions:
>
> 1) Is it ok in general to remove deprecated API in a non X.0 release (eg
> geode 1.10 instead of geode 2.0)?
>
> 2) How about in this case, when this feature has been deprecated for so
> long, and may or may not work?
>
> -Dan
>
> [1]
> https://geode.apache.org/releases/latest/javadoc/org/apache/geode/admin/package-summary.html
> [2] Draft PR for moving the org.apache.geode.admin to a separate module -
> https://github.com/apache/geode/pull/3392
>

Mime
View raw message