From dev-return-30842-archive-asf-public=cust-asf.ponee.io@geode.apache.org Thu Mar 21 00:08:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1B40418062C for ; Thu, 21 Mar 2019 01:08:58 +0100 (CET) Received: (qmail 54620 invoked by uid 500); 21 Mar 2019 00:08:58 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 54608 invoked by uid 99); 21 Mar 2019 00:08:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Mar 2019 00:08:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E478A180779 for ; Thu, 21 Mar 2019 00:08:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.798 X-Spam-Level: * X-Spam-Status: No, score=1.798 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6tukKAISY43x for ; Thu, 21 Mar 2019 00:08:54 +0000 (UTC) Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D357D61154 for ; Thu, 21 Mar 2019 00:08:53 +0000 (UTC) Received: by mail-vk1-f180.google.com with SMTP id d15so995857vka.8 for ; Wed, 20 Mar 2019 17:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=sxZOQlvRtBOJ7FhkQ26Mq9j3RI9u0X8wmecYPqJD42w=; b=TB0H7KgiFGpe0w1YQ+dnlLyN2RoKXZyVNcQHLveuW9lMcUwWhpsJqAKqDIW5znhwNN LLPFceFmV6aQaK181E+ymcFv33VebYN0rEmMuZomAB/+M2s1R6ceixWB8QVcb9gXSSlD +mdMU69TN/uTew5WY94tJ+KREpWChFDZ1GftbbsrAZZCCzOcyZ1oI5QQSnOys9QKpQKi 4a2OOv7NNOTXOmEyM+YYOp0hZPAabVHJyiMwrs01LTSo4OAtpYof8+oEordjBUHMosrp 1EI0WZ8cH8UV1Xt5EnPYZZLCjsriFvDfnOoqp1C7Eg1nCTsthdo2SpPcA68FhGyUwB6b hckA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=sxZOQlvRtBOJ7FhkQ26Mq9j3RI9u0X8wmecYPqJD42w=; b=MjechTHm7tTePu007DZvfK7sI6dVn3lo58j/qALQnLLBTTOI7eKomq1aN97OTGZK5H N4mpMYl8gHYsMic+yy0rFnSBFRvvbQE40TfOEnRwBdR3GzdGBGPyJyWzRJk3kXIxK7PR QJMfygr1fGMsjsxT8N7ZCg/dqwwF2ES8WUdAGywyc7ZODvK/bcSAHol25WdxaHeyPQWx qVzG6EmsOkumg8okS3EnbD0JJRGJSrB1hWHVWcCULNw3dNnmDJEUUQgx8i4pQVCJGYrz TCJaCQNwDhwKtOO0h4Klj/CRje4JZYzGAcA8tyvvNkod6TT3vrEZjdrB1TDD4dTaw2V0 FT0Q== X-Gm-Message-State: APjAAAXK92CJeRJKcwwdWmNi4NP/1Ax/Es0I5ZwmgEsyAaEaG2n+NGy3 csGBLzT5I66vd7aWLXttKTfASo4qBW6ZIT7XaV0xbxck X-Google-Smtp-Source: APXvYqyxhyVsmpDXNBTu9RnmFamYZBEPrIHyuH2+fowWHNUHZPCsPDm+pXzMY5sZzBRk4mMlRJLjTLrPrHe32Bvl+Tk= X-Received: by 2002:a1f:5085:: with SMTP id e127mr629099vkb.38.1553126926309; Wed, 20 Mar 2019 17:08:46 -0700 (PDT) MIME-Version: 1.0 References: <3bc82003-c1ba-565d-31c2-8e855e2e30e1@pivotal.io> <23D49018-3CDC-4BD0-9710-C1C2E376CC5F@pivotal.io> In-Reply-To: From: Sai Boorlagadda Date: Wed, 20 Mar 2019 17:08:34 -0700 Message-ID: Subject: Re: [DISCUSS] Proposal to re-cut Geode 1.9.0 release branch To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="000000000000bbdf9d05848f8a0e" --000000000000bbdf9d05848f8a0e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I would like to resolve the issue around NOTICE and LICENSE files related to new/removed dependencies on develop, which I have a PR[1] open and would need some guidance. There is some feedback provided by Dick earlier this week and I would like to see if I can get some help. [1] https://github.com/apache/geode/pull/3313 On Wed, Mar 20, 2019 at 12:43 PM Dale Emery wrote: > > On Mar 20, 2019, at 11:25 AM, Alexander Murmann > wrote: > > > > Dale, is there any downside to making these changes in 1.10 other than > > plainly having them later? > > I don=E2=80=99t think so, but I=E2=80=99d want to hear Dan=E2=80=99s opin= ion on that, given that > his approval of our PR was contingent on our promise to do it. > > FYI, the additional work to improve usability is non-trivial, which is wh= y > we haven=E2=80=99t done it already. > > =E2=80=94 > Dale Emery > demery@pivotal.io > > > > > On Mar 20, 2019, at 11:25 AM, Alexander Murmann > wrote: > > > > Dale, is there any downside to making these changes in 1.10 other than > > plainly having them later? > > > > On Wed, Mar 20, 2019 at 11:15 AM Dave Barnes wrote= : > > > >> geode-native is ready to into the 1.9 release candidate build. > >> > >> On Wed, Mar 20, 2019 at 10:42 AM Dave Barnes > wrote: > >> > >>> The geode-native PR will be ready to check in momentarily. Just waiti= ng > >>> for Travis to do its diligence. > >>> > >>> On Wed, Mar 20, 2019 at 9:47 AM Alexander Murmann > > >>> wrote: > >>> > >>>> Dale, do I understand correctly that the only concern around the > >>>> Micrometer > >>>> work right now it that it's not useful yet, however it's not harmful > >>>> either? > >>>> > >>>> Dave, is it correct that if that PR doesn't make it into the newly c= ut > >>>> branch, we'd be shipping with a older version of geode-native? What > are > >>>> the > >>>> two versions and what would be the implications of this not making i= t > >> into > >>>> this release? > >>>> > >>>> On Tue, Mar 19, 2019 at 5:29 PM Dave Barnes > wrote: > >>>> > >>>>> The Geode 1.9.0 release includes a source-only release of the > >>>> geode-native > >>>>> repo. There's a pull-request in process to update version numbers a= nd > >>>> the > >>>>> doc build environment in that repo; should be ready to merge tomorr= ow > >>>>> morning. > >>>>> > >>>>> On Tue, Mar 19, 2019 at 5:20 PM Dale Emery > wrote: > >>>>> > >>>>>> The Micrometer API is in, and marked as experimental. But we have > >> not > >>>> yet > >>>>>> updated CacheFactory to allow injecting a meter registry (or metri= cs > >>>>>> publishing service) there. So currently the only way to publish is > >> to > >>>> add > >>>>>> metrics publishing service via the ServiceLoader mechanism. > >>>>>> > >>>>>> =E2=80=94 > >>>>>> Dale Emery > >>>>>> demery@pivotal.io > >>>>>> > >>>>>> > >>>>>>> On Mar 19, 2019, at 3:29 PM, Dan Smith wrote: > >>>>>>> > >>>>>>> Is the geode-managability sub-project and the new micrometer API > >> in > >>>> a > >>>>>> place > >>>>>>> where we can cut a release branch? I know a bunch of changes have > >>>> gone > >>>>> in > >>>>>>> since the release branch, are we comfortable releasing these new > >>>>>>> experimental features as they are right now? > >>>>>>> > >>>>>>> -Dan > >>>>>>> > >>>>>>> On Tue, Mar 19, 2019 at 2:38 PM Dick Cavender > >>>>> wrote: > >>>>>>> > >>>>>>>> +1 to re-cutting the 1.9 release branch off a more stable develo= p > >>>> sha > >>>>>>>> within the last couple days. > >>>>>>>> > >>>>>>>> On Tue, Mar 19, 2019 at 1:14 PM Bruce Schuchardt < > >>>>>> bschuchardt@pivotal.io> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> If we recut the release branch we need to update JIRA tickets > >>>> marked > >>>>>>>>> fixed in 1.10 > >>>>>>>>> > >>>>>>>>> On 3/19/19 12:48 PM, Sai Boorlagadda wrote: > >>>>>>>>>>> It was known at the time that develop was not as stable as > >>>> desired, > >>>>>>>>>> so we planned to cherry-pick fixes from develop until the > >> release > >>>>>>>>>> branch was stable enough to ship. > >>>>>>>>>> I want to clarify that we decided to cut the release branch no= t > >>>> that > >>>>>>>>>> develop was not stable. But really that it is desirable to cut > >>>> the > >>>>>>>>>> branch sooner to avoid any regression risk that can be > >>>> introduced by > >>>>>>>>>> on-going work on develop. > >>>>>>>>>> > >>>>>>>>>> Nevertheless looks like develop is more stable than release > >>>> branch > >>>>> due > >>>>>>>>>> to some test fixes that were not cherry-picked into the releas= e > >>>>>> branch. > >>>>>>>>>> I think its a good idea to re-cut the branch as our current > >>>> position > >>>>>>>>>> to stabilize release branch before releasing. > >>>>>>>>>> > >>>>>>>>>> +1 to re-cut. > >>>>>>>>>> > >>>>>>>>>> Sai > >>>>>>>>>> > >>>>>>>>>> On Tue, Mar 19, 2019 at 12:19 PM Owen Nichols < > >>>> onichols@pivotal.io > >>>>>>>>>> > wrote: > >>>>>>>>>> > >>>>>>>>>> The Geode 1.9.0 release branch was originally cut 4 weeks > >> ago > >>>> on > >>>>>>>>>> Feb 19. It was known at the time that develop was not as > >>>> stable > >>>>>>>>>> as desired, so we planned to cherry-pick fixes from develop > >>>> until > >>>>>>>>>> the release branch was stable enough to ship. While this > >> is a > >>>>>>>>>> good strategy when starting from a fairly good baseline, it > >>>> seems > >>>>>>>>>> in this case it has only added complexity without leading to > >>>>>>>>>> stability. > >>>>>>>>>> > >>>>>>>>>> Looking at the pipelines over the last week (see attached > >>>>>>>>>> metrics), it appears we have been far more successful at > >>>>>>>>>> stabilizing /develop/ than /release/1.9.0/. Rather than > >>>> trying to > >>>>>>>>>> cherry-pick more and more fixes to the release branch, I > >>>> propose > >>>>>>>>>> we RE-CUT the 1.9.0 release branch later this week in order > >> to > >>>>>>>>>> start from a much more stable baseline. > >>>>>>>>>> > >>>>>>>>>> -Owen > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>>>> > >>>>>> > >>>>> > >>>> > >>> > >> > > > > > > -- > > Alexander J. Murmann > > (650) 283-1933 > > --000000000000bbdf9d05848f8a0e--