From dev-return-30387-archive-asf-public=cust-asf.ponee.io@geode.apache.org Mon Dec 3 22:54:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B286180645 for ; Mon, 3 Dec 2018 22:54:17 +0100 (CET) Received: (qmail 3673 invoked by uid 500); 3 Dec 2018 21:54:16 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 3657 invoked by uid 99); 3 Dec 2018 21:54:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2018 21:54:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 73109CA158 for ; Mon, 3 Dec 2018 21:54:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.749 X-Spam-Level: ** X-Spam-Status: No, score=2.749 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id OXfttlRkX5Nd for ; Mon, 3 Dec 2018 21:54:11 +0000 (UTC) Received: from mx0a-00296801.pphosted.com (mx0a-00296801.pphosted.com [148.163.150.38]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B5242610EC for ; Mon, 3 Dec 2018 21:43:37 +0000 (UTC) Received: from pps.filterd (m0114582.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wB3LfEUr014992 for ; Mon, 3 Dec 2018 21:43:36 GMT Received: from mail-it1-f200.google.com (mail-it1-f200.google.com [209.85.166.200]) by mx0a-00296801.pphosted.com with ESMTP id 2p3h25hvu1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 03 Dec 2018 21:43:35 +0000 Received: by mail-it1-f200.google.com with SMTP id t143so10193407itc.9 for ; Mon, 03 Dec 2018 13:43:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=RzwNwGNMZ22I7rIPRWYGxndQDV1+jIvNJo2pdka387g=; b=O6wmgc78AKXNR+5OY3mocHY7b0tAmBq2dxsA4nX3gD0nRDuLfvU8xhy4pDT7x8zfXb 90y6T/pWcgmfNHRqwA5bAoHshBeOG5s4ys2NZ1wcfoHawaWiHYxVvTfdtuHJNAY1p1Va Xq63hgO4x7yrJ6r10bwe5l3b7Kh7KhbwNnRWHOx0R0PCvQw+MOl8RT80tsb14oOnQ+eG tQTEWYQWTbzNkdrlVjeJF0nZrRM9Udljav5QJmVAuRRTML6I1R2DHrUJfqaYvbzmFAMw yujQ4KaxWy20HC5YLyWZdaDzdj4cNmFI4DS/4NMwmWsJnwkyWIhn0UB0eZzVsPsWSjwO Z8NA== X-Gm-Message-State: AA+aEWasIlCdfTpGUckAzAD1MgE1IoXAxSsGT8tUmJ5uKqvMs9Xz3XNp ul0fvcxbLsN3PbvXuF4zDUC1nO9erNKagNQ4paBoQJCaMmAs9rMKnnC3sKDvAXY7wz+gjJKSng0 oPhlR2fX6+Nvc9EQfui1GAm/f4pcm+7JnuCFFplCupOfmf7ObPk9UirI= X-Received: by 2002:a6b:242:: with SMTP id 63mr15503877ioc.118.1543873414385; Mon, 03 Dec 2018 13:43:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/XpmY5Kw2VmtjprLJGOOeP2cdlrOxjjVjnWDIDTAbEl9jNP4Uk2ggLdkYntcBAgv0MOaxpaVND4uo9uKzmGxus= X-Received: by 2002:a6b:242:: with SMTP id 63mr15503858ioc.118.1543873413884; Mon, 03 Dec 2018 13:43:33 -0800 (PST) MIME-Version: 1.0 References: <20B7768D-2454-45A6-B382-BA0786569F30@pivotal.io> <3710831B-C176-45F4-A41F-5C6ADC2978F5@pivotal.io> In-Reply-To: From: Dan Smith Date: Mon, 3 Dec 2018 13:43:22 -0800 Message-ID: Subject: Re: [VOTE] Apache Geode 1.8.0 RC1 To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="00000000000069ce59057c250abb" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-03_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812030195 --00000000000069ce59057c250abb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I see some issues with the native source release that I think are a problem= . I looked into the travis for the native code - it looks like travis is passing, but finding files with missing license headers? Eg /geode-native/clicache/src/native_shared_ptr.hpp. https://travis-ci.org/apache/geode-native/jobs/462048991 I also see some binary executable files in the native source distribution, which I don't even see in github. Is this cruft from somone's build workspace? ./cmake-build-debug/CMakeFiles/3.12.3/CMakeDetermineCompilerABI_CXX.bin: Mach-O 64-bit executable x86_64 ./cmake-build-debug/CMakeFiles/3.12.3/CMakeDetermineCompilerABI_C.bin: Mach-O 64-bit executable x86_64 ./cmake-build-debug/CMakeFiles/3.12.3/CompilerIdC/a.out: Mach-O 64-bit executable x86_64 ./cmake-build-debug/CMakeFiles/3.12.3/CompilerIdCXX/a.out: Mach-O 64-bit executable x86_64 ./cmake-build-debug/CMakeFiles/feature_tests.bin: Mach-O 64-bit executable x86_64 Regarding the java parts of the release - I think the java bits look okay now. I dug up the old email conversation and we did agree to remove the zip distribution. The new signatures look good. -Dan On Mon, Dec 3, 2018 at 12:02 PM Alexander Murmann wrote: > Thanks again for all the input! > > Both Geode and Geode Native source distributions are now signed with an > armored signature. > Release manager docs are updated accordingly. > > I also added tickets to make the geode build also the sign source release > and increase the > checksum to SHA 512 for core > and examples > . > > If we agree on not having a ZIP file for core and native we should be > consistent in the next release and remove the ZIPs form examples as well. > > On Mon, Dec 3, 2018 at 10:23 AM Robert Houghton > wrote: > > > +1. Thanks Owen > > > > On Mon, Dec 3, 2018, 10:07 Owen Nichols > > > > > 2. No zip file for the geode, just .tgz. > > > > > > I believe this was changed a few months ago to simplify our build and > > > release process. Distributing as both .zip and .tgz is a relic of a > time > > > before WinZip, WinRar, 7-Zip, and most other popular zip utilities > gained > > > native support for .tgz archives. If there is still a segment of the > > Geode > > > user community that would suffer hardship due to lack of .zip > packaging, > > we > > > should revisit this decision. > > > > > > -Owen > > > > > > > > > > On Dec 3, 2018, at 9:52 AM, Dan Smith wrote: > > > > > > > > I see a few things with the artifacts that I think should be tweake= d > > > > 1. No pgp signature for the sources! > > > > 2. No zip file for the geode, just .tgz. Older releases on our > website > > > have > > > > both zip and tgz. See the differences between [1] and [2] > > > > 3. pgp signature for the native source is not ascii armored. See [3= ] > > > > > > > > Regarding SHA512 vs SHA256 - we should probably just move everythin= g > to > > > > SHA512 in the future. > > > > > > > > [1] https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC1/ > > > > [2] https://www.apache.org/dist/geode/1.7.0/ > > > > [3] https://www.apache.org/dev/release-signing.html#signing-basics > > > > > > > > On Mon, Dec 3, 2018 at 9:24 AM Alexander Murmann < > amurmann@pivotal.io> > > > > wrote: > > > > > > > >> Thanks for taking such a detailed a look, Nabarun! That's awesome > > input. > > > >> > > > >> 1. Is there a reason why geode-native is signed with SHA512 while > all > > > the > > > >>> rest are signed with SHA256? > > > >> > > > >> Not really. I used the defaults provided by the Gradle signing tas= k > in > > > the > > > >> case of the core codebase and the GPG tool's default when signing > the > > > >> native code. I noticed that GPG's default was larger, but figured > more > > > bits > > > >> are better bits and come at pretty much no additional cost. If thi= s > is > > > >> confusing, I am happy to sign with a smaller hash or at least at > > > >> documentation for doing so more consistently in the next release. > > > >> Any opinions on how to proceed with this? > > > >> > > > >> 2. Are there any directions / documentation on how to verify the > > > >>> geode-native release components? > > > >> > > > >> I unpacked the release and followed the instructions in building.m= d. > > > >> Someone who has contributed more to the Native code base might hav= e > > much > > > >> better steps in mind. Pleas chime in! > > > >> > > > >> On Mon, Dec 3, 2018 at 8:45 AM Nabarun Nag wrote= : > > > >> > > > >>> Following checks completed: > > > >>> - checked signatures > > > >>> - checked SHA's > > > >>> - builds from source [geode] > > > >>> - run gfsh - start locator, server - create region - do put and > get - > > > >>> execute OQL query > > > >>> - examples run cleanly [geode-examples] > > > >>> - the correct version in gfsh command version > > > >>> > > > >>> Questions: > > > >>> 1. Is there a reason why geode-native is signed with SHA512 while > all > > > the > > > >>> rest are signed with SHA256? > > > >>> 2. Are there any directions / documentation on how to verify the > > > >>> geode-native release components? > > > >>> > > > >>> > > > >>> File Differences: > > > >>> 1. Files KEYS and gradlew.bat are present in the github repo for > > > >>> rel/v1.8.0.RC1 but not present in the source release > > > >> apache-geode-1.8.0-src > > > >>> 2. gradlew file differs in the rel/v1.8.0.RC1 repo and the source > > > release > > > >>> apache-geode-1.8.0-src. > > > >>> > > > >>> Apologies if these changes are expected. > > > >>> > > > >>> Regards > > > >>> Nabarun Nag > > > >>> > > > >>> > > > >>> > > > >>> > > > >>> On Fri, Nov 30, 2018 at 5:38 PM Alexander Murmann < > > amurmann@pivotal.io > > > > > > > >>> wrote: > > > >>> > > > >>>> Hi everyone, > > > >>>> > > > >>>> Per above discussion the release now contains Geode Native. > > > >>>> Here is the updated release information: > > > >>>> > > > >>>> Apache Geode: > > > >>>> https://github.com/apache/geode/tree/rel/v1.8.0.RC1 > > > >>>> Apache Geode examples: > > > >>>> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC1 > > > >>>> Apache Geode Native: > > > >>>> https://github.com/apache/geode-native/tree/rel/v1.8.0.RC1 > > > >>>> > > > >>>> Commit IDs: > > > >>>> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e > > > >>>> Apache Geode Examples: aee3794f1302ffab51b4ca5d02657598420b7a00 > > > >>>> Apache Geode Native: 32d71d13087b5c1a36417693cf8da9a8819edbdf > > > >>>> > > > >>>> Source and binary files: > > > >>>> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC1/ > > > >>>> > > > >>>> Maven staging repo: > > > >>>> > > > https://repository.apache.org/content/repositories/orgapachegeode-104= 8 > > > >>>> > > > >>>> Geode's KEYS file containing PGP keys we use to sign the release= : > > > >>>> https://github.com/apache/geode/blob/develop/KEYS > > > >>>> > > > >>>> Signed the release with fingerprint: > > > >>>> rsa4096 2018-09-01 [SC] > > > >>>> D5C5C950D61898EDE8928820D6048392BDFB7797 > > > >>>> > > > >>>> > > > >>>> On Fri, Nov 30, 2018 at 9:44 AM Anthony Baker > > > >> wrote: > > > >>>> > > > >>>>> Because this is confusing, let me clarify our current approach > > again: > > > >>>>> > > > >>>>> When we do a release of the Geode Project, it will include all > the > > > >>>>> constituent pieces we deem appropriate regardless of the repo t= he > > > >>> source > > > >>>>> comes from. Currently this includes: > > > >>>>> > > > >>>>> - geode > > > >>>>> - geode-examples > > > >>>>> - geode-native > > > >>>>> > > > >>>>> Perhaps in the future, we would include geode-benchmarks. > > > >>>>> > > > >>>>> In order to create a distinct release with a separate lifecycle > we > > > >>> would > > > >>>>> need to spawn a subproject with a separate PMC and a viable > > > >> community. > > > >>>>> > > > >>>>> @Alexander, I don=E2=80=99t think you need to issue a new relea= se > > candidate. > > > >>>> Just > > > >>>>> add the geode-native source distribution and update the VOTE > email. > > > >>>>> > > > >>>>> > > > >>>>> Anthony > > > >>>>> > > > >>>>> > > > >>>>>> On Nov 30, 2018, at 8:08 AM, Alexander Murmann < > > > >> amurmann@pivotal.io> > > > >>>>> wrote: > > > >>>>>> > > > >>>>>> Sorry, I was unaware that we were planning on releasing > > > >> geode-native > > > >>> as > > > >>>>>> part of the same release and not as a separate release that go= es > > > >> out > > > >>>> at a > > > >>>>>> similar time. > > > >>>>>> > > > >>>>>> I am happy to work on a new candidate that includes > geode-native. > > > >>>>>> > > > >>>>>> On Fri, Nov 30, 2018 at 6:39 AM Anthony Baker < > abaker@pivotal.io> > > > >>>> wrote: > > > >>>>>> > > > >>>>>>> Is there a reason the geode-native repo was not included in t= he > > > >>>> release? > > > >>>>>>> > > > >>>>>>> Anthony > > > >>>>>>> > > > >>>>>>> > > > >>>>>>>> On Nov 29, 2018, at 11:15 PM, Alexander Murmann < > > > >>> amurmann@pivotal.io > > > >>>>> > > > >>>>>>> wrote: > > > >>>>>>>> > > > >>>>>>>> Hello Geode dev community! > > > >>>>>>>> > > > >>>>>>>> I am happy to announce the first release candidate for Apach= e > > > >> Geode > > > >>>>>>> 1.8.0! > > > >>>>>>>> Thanks to all the community members for their contributions = to > > > >> this > > > >>>>>>>> release! > > > >>>>>>>> > > > >>>>>>>> Please review and give your feedback! The deadline is the en= d > of > > > >>> day > > > >>>>> Dec. > > > >>>>>>>> 4th 2018. > > > >>>>>>>> > > > >>>>>>>> It resolves 162 issues on Apache Geode JIRA system. Release > > notes > > > >>> can > > > >>>>> be > > > >>>>>>>> found at: > > > >>>>>>>> > > > >>>>>>> > > > >>>>> > > > >>>> > > > >>> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNo= tes-1.8.0 > > > >>>>>>>> > > > >>>>>>>> Please note that we are voting upon the source tags: > > > >> rel/v1.8.0.RC1 > > > >>>>>>>> Apache Geode: > > > >>>>>>>> https://github.com/apache/geode/tree/rel/v1.8.0.RC1 > > > >>>>>>>> Apache Geode examples: > > > >>>>>>>> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC1 > > > >>>>>>>> > > > >>>>>>>> Commit IDs: > > > >>>>>>>> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e > > > >>>>>>>> Apache Geode Examples: > aee3794f1302ffab51b4ca5d02657598420b7a00 > > > >>>>>>>> > > > >>>>>>>> Source and binary files: > > > >>>>>>>> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC1/ > > > >>>>>>>> > > > >>>>>>>> Maven staging repo: > > > >>>>>>>> > > > >>>> > > > https://repository.apache.org/content/repositories/orgapachegeode-104= 8 > > > >>>>>>>> > > > >>>>>>>> Geode's KEYS file containing PGP keys we use to sign the > > release: > > > >>>>>>>> https://github.com/apache/geode/blob/develop/KEYS > > > >>>>>>>> > > > >>>>>>>> Signed the release with fingerprint: > > > >>>>>>>> rsa4096 2018-09-01 [SC] > > > >>>>>>>> D5C5C950D61898EDE8928820D6048392BDFB7797 > > > >>>>>>>> > > > >>>>>>>> PS: Command to run geode-examples: ./gradlew > -PgeodeReleaseUrl=3D > > > >>>>>>>> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC1 > > > >>>>>>> -PgeodeRepositoryUrl=3D > > > >>>>>>>> > > > >>>> > > > https://repository.apache.org/content/repositories/orgapachegeode-104= 8 > > > >>>>>>>> build runAll > > > >>>>>>>> > > > >>>>>>>> Thank you! > > > >>>>>>>> Alexander > > > >>>>>>> > > > >>>>>>> > > > >>>>> > > > >>>>> > > > >>>> > > > >>> > > > >> > > > > > > > > > --00000000000069ce59057c250abb--