geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@apache.org>
Subject PR review requests
Date Wed, 26 Dec 2018 17:27:31 GMT
If anyone is free to review a couple PRs, please take a look at mine:

GEODE-3205: Cleanup and reenable DiskSpaceLimitIntegrationTest
https://github.com/apache/geode/pull/3035
- basically, the FILE_SIZE_LIMIT_BYTES was too small, resulting in rolling
too many
- added lots more info in assertion failures and other changes to cleanup
the test

GEODE-6143: Import methods from Mockito instead of PowerMockito
https://github.com/apache/geode/pull/2978
- imported when from Mockito instead of PowerMockito
- removed unnecessary uses of final keyword and changed test to more
closely follow junit coding conventions

Thanks,
Kirk

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message