geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Murmann <amurm...@pivotal.io>
Subject Re: Default branch for geode-examples
Date Wed, 12 Dec 2018 17:50:44 GMT
I agree that there is a conflict here of what might be most usable for
users vs. developers contributing to the geode-examples repo.

No matter which route we go down, we should improve guidance. If we keep
master the default, I +1 Owen's suggestion of amending the template. If we
make develop the default, we should amend the readme to recommend either
downloading the release TGZ or cloning the corresponding SHA.

On Wed, Dec 12, 2018 at 9:43 AM Owen Nichols <onichols@pivotal.io> wrote:

> I believe master is still the best default branch for most users.  Can we
> add a PR template for geode-examples reminding developers that examples PRs
> must be based on develop, not master?
>
> Generally the only difference between examples' develop and master is
> which maven repo it points to (snapshot and release, respectively).  I
> assume the Geode release process include a step for merging changes from
> develop to master after each release?
>
> -Owen
>
> > On Dec 12, 2018, at 9:24 AM, Anthony Baker <abaker@pivotal.io> wrote:
> >
> > I’m fine with moving all development work to master given the use case
> for geode-examples—I just don’t want PR’s merged to *both* master and
> develop.
> >
> > Other thoughts?
> >
> > Anthony
> >
> >
> >> On Dec 12, 2018, at 9:16 AM, Dan Smith <dsmith@pivotal.io> wrote:
> >>
> >> Good  question! I think we intentionally left the default branch as
> master
> >> so that users cloning the examples from github will get examples that
> work
> >> against a released version of geode.
> >>
> >> That said, I don't feel too strongly if we would rather make things more
> >> consistent with the geode repo - it seems like we also try to keep
> develop
> >> stable.
> >>
> >> -Dan
> >>
> >> On Wed, Dec 12, 2018 at 9:07 AM Anthony Baker <abaker@pivotal.io>
> wrote:
> >>
> >>> Alexander noticed that some recent PR’s against the geode-examples repo
> >>> made against the master branch.  That breaks the gitflow approach where
> >>> only released code is on master.  Should we update the default branch
> to be
> >>> develop?
> >>>
> >>>
> >>> Anthony
> >>>
> >>>
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message