From dev-return-30163-archive-asf-public=cust-asf.ponee.io@geode.apache.org Thu Nov 8 23:32:13 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7F372180671 for ; Thu, 8 Nov 2018 23:32:12 +0100 (CET) Received: (qmail 79168 invoked by uid 500); 8 Nov 2018 22:32:11 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 79151 invoked by uid 99); 8 Nov 2018 22:32:11 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2018 22:32:11 +0000 Received: from MacBook-Pro-5.local (50-203-225-134-static.hfc.comcastbusiness.net [50.203.225.134]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 924B41727 for ; Thu, 8 Nov 2018 22:32:10 +0000 (UTC) Subject: Re: Lombok To: dev@geode.apache.org References: From: Udo Kohlmeyer Message-ID: <6ec0b39b-7a18-9697-6b0f-2b1e94493cb7@apache.org> Date: Thu, 8 Nov 2018 14:32:09 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US I know that this is "pedantic".. but to me "isDiskSynchronous" reads better than "getDiskSynchronous" but in the end, it returns the declared field. Kotlin's data class on the other plays a little "nicer". If you define the field as "isDiskSynchronous" the generated getter is "isDiskSynchronous()". Would Lombok respect similar semantics? --Udo On 11/8/18 13:57, Aditya Anchuri wrote: > Note: If the PR gets accepted, people that use IntelliJ idea or Eclipse > will need to use the Lombok plugin for their respective IDEs -- for > IntelliJ people will also need to enable annotation processing in the > compiler settings if not already enabled. > > On Thu, Nov 8, 2018 at 12:02 PM Aditya Anchuri wrote: > >> I've only touched a few classes in my PR, but I feel like there's a lot >> more boilerplate floating around that can be removed. Having said that, I >> agree with your point regarding Kotlin, but for the Java code I would find >> Lombok pretty useful. Have included a link to the PR: >> >> https://github.com/apache/geode/pull/2815 >> >> -Aditya >> >> >> >> On Thu, Nov 8, 2018 at 11:24 AM Udo Kohlmeyer wrote: >> >>> The Spring world/community are heavy users of Lombok. >>> >>> In essence it is "nice", BUT it does now add a new dependency on a >>> library that is to provide functionality that developers should provide. >>> IJ Idea does provide support for Lombok. >>> >>> I have not yet seen any code bloat that Lombok could reduce for us. >>> Also, the reduction is only in terms of "visible", the compiled class >>> might be more verbose. >>> >>> Kotlin on the other hand, as some of the boilerplate code built in as a >>> language feature. I prefer that over choosing a library, that might have >>> compatibility issues in the future. >>> >>> Also, Kotlin's conciseness is also a language feature rather than >>> library plugin. I've also seen cases where compiled Java was larger than >>> the equivalent compiled Kotlin code. >>> >>> --Udo >>> >>> >>> On 11/8/18 10:31, Aditya Anchuri wrote: >>>> Hi everyone, >>>> >>>> I am considering adding Lombok as a compile-time dependency ( >>>> https://projectlombok.org/) so we can reduce the amount of boilerplate >>> code >>>> and reduce the size of some of our classes. I have a small proof of >>> concept >>>> PR ready to go. Before I do so, I want to find out if people have tried >>> it >>>> before and how they feel about it, especially when used with IDEs like >>>> IntelliJ and/or Eclipse? >>>> >>>> Thanks, >>>> -Aditya >>>> >>>