geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <>
Subject Re: [DISCUSS] LGTM on pull requests
Date Fri, 09 Nov 2018 22:33:00 GMT
FindBugs is another one that could potentially help some. I get tired of
adding reviews that say "Please change this member variable to be private"
-- tools like LGTM and FindBugs can help guide us to better code and
prevent us from losing ground in something like the improvements you all
have made for LGTM. Thanks by the way!

On Fri, Nov 9, 2018 at 2:20 PM, Bruce Schuchardt <>

> I'd like to see LGTM run on pull requests.  Otherwise I think we're
> fighting a losing battle trying to improve the quality of our code. For
> instance, we just had a nice contribution of geospatial functionality that
> raised 5 alerts, but we only found out about it after the code was merged
> to develop.
> LGTM allows that kind of integration but you have to be the repo "owner"
> to set it up.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message