geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aditya Anchuri <aanch...@pivotal.io>
Subject Re: [DISCUSS] LGTM on pull requests
Date Fri, 09 Nov 2018 22:32:55 GMT
+1, although I do wonder about the overhead of making PRs increasing more
than it already feels like to me as a new contributor (as the person who
made the geospatial contribution). If this was a gradle task maybe like
spotless?

On Fri, Nov 9, 2018 at 2:20 PM Bruce Schuchardt <bschuchardt@pivotal.io>
wrote:

> I'd like to see LGTM run on pull requests.  Otherwise I think we're
> fighting a losing battle trying to improve the quality of our code. For
> instance, we just had a nice contribution of geospatial functionality
> that raised 5 alerts, but we only found out about it after the code was
> merged to develop.
>
> LGTM allows that kind of integration but you have to be the repo "owner"
> to set it up.
>
>
> https://lgtm.com/projects/g/apache/geode/
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message