geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Rhomberg <prhomb...@apache.org>
Subject Re: A small proposal: Not Sorting in AnalyzeSerializablesJUnitTest
Date Tue, 13 Nov 2018 18:28:49 GMT
I categorically like style improvement and enforcement.

+1 to this specific style improvement and enforcement.

It's pretty straight-forward to write a regex into our spotless.gradle.
Let me know if you need a hand on that front, since I know I shouldn't use
"straightforward" to refer to either of regex or gradle.

On Mon, Nov 12, 2018 at 5:28 PM, Galen O'Sullivan <gosullivan@pivotal.io>
wrote:

> Hi all,
>
> I wrote a PR (GEODE-5800) recently to remove redundant cases from
> DataSerializer.readObject etc. calls. This changed the bytecode size (but
> not the behavior) of a number of DataSerializables, and I realized that the
> task of updating the list (or viewing the diff) was made harder by the fact
> that our sanctionedDataSerializables list has gotten out of order. I would
> like to propose forcing the list (and probably sanctionedSerializables as
> well) to be ordered and the files to be equal, as I see no benefit to
> having the files out of order, and I do see a benefit to having
> configuration files like this rigidly defined so that we can analyze and
> read diffs better.
>
> Thoughts?
>
> Thanks,
> Galen
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message