geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Owen Nichols <onich...@pivotal.io>
Subject Re: Spotless Check failing on Windows?
Date Mon, 12 Nov 2018 04:47:50 GMT
The pipeline does actually build on Windows, but with -x spotlessCheck

Someone (maybe whoever’s touched th spotless rules most recently) might
know what to do. I tend to agree that the same source code ought to be able
to pass spotless on both Linux and windows; and our pipeline should
probably be tweaked to ensure this gets tested.

On Sun, Nov 11, 2018 at 8:35 PM Michael Oleske <moleske@pivotal.io> wrote:

> Hi Geode Dev Friends!
>
> I was building the latest off of develop (hash 75d7ed8a49d6) in PowerShell
> on my Windows box and noticed during build that the spotless check failed.
> It strangely fails on line endings (\r\n fun times) on what seems to be all
> (or at least 34 of them) build.gradle files.  This seems odd to me since I
> didn't realize that spotless check actually checked more than just java
> files.  I assume no pipeline picked this up since the pipelines would build
> once and pass the jar around rather than build on Windows and Linux (since
> JVM and all that).  I haven't tracked down when this started happening to
> me (though I can if that is of interest to people).
>
> If anyone has any thoughts I'd like to hear (even if they are just why
> Windows why!)
>
> -michael
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message