geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Barrett <jbarr...@pivotal.io>
Subject Re: [DISCUSS] Disable merge for failing pull requests
Date Sat, 10 Nov 2018 00:23:43 GMT
-1

I think there is still plenty of flakiness in the tests that PRs can go red
due to something flaky. Blocking a merge when the issue is known to be
flaky would be disruptive to progress. I think it will also just encourage
someone to use direct pushing to work around false reds. This might lead to
even worse transgressions, like merging changes without PRs.

Do we really have a problem with someone merging legitimately broken PRs?


On Fri, Nov 9, 2018 at 12:55 PM Dan Smith <dsmith@pivotal.io> wrote:

> Hi all,
>
> Kirks emails reminded me - I think we are at the point now with our PR
> checks where we should not be merging anything to develop that doesn't pass
> all of the PR checks.
>
> I propose we disable the merge button unless a PR is passing all of the
> checks. If we are in agreement I'll follow up with infra to see how to make
> that happen.
>
> This would not completely prevent pushing directly to develop from the
> command line, but since most developers seem to be using the github UI, I
> hope that it will steer people towards getting the PRs passing instead of
> using the command line.
>
> Thoughts?
> -Dan
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message