From dev-return-29701-archive-asf-public=cust-asf.ponee.io@geode.apache.org Thu Sep 13 01:07:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3BB80180630 for ; Thu, 13 Sep 2018 01:07:39 +0200 (CEST) Received: (qmail 58141 invoked by uid 500); 12 Sep 2018 23:07:38 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 58124 invoked by uid 99); 12 Sep 2018 23:07:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2018 23:07:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 16E8DC98CD for ; Wed, 12 Sep 2018 23:07:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.299 X-Spam-Level: * X-Spam-Status: No, score=1.299 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gpL5LuB_pICq for ; Wed, 12 Sep 2018 23:07:35 +0000 (UTC) Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BE74C5F43B for ; Wed, 12 Sep 2018 23:07:34 +0000 (UTC) Received: from pps.filterd (m0114585.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8CMpcg8024368 for ; Wed, 12 Sep 2018 23:07:34 GMT Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by mx0b-00296801.pphosted.com with ESMTP id 2mc6k4m3qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Sep 2018 23:07:34 +0000 Received: by mail-oi0-f71.google.com with SMTP id p14-v6so4433309oip.0 for ; Wed, 12 Sep 2018 16:07:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=9poi1ipwDN+1QrBUuLhzZ2YWNsdDXVmsGglvYCV0oCo=; b=oO1Hew9K6ODTS2mKX67Du/T9/CkGgMwj6lAxBoHzl+druEkQMozUNs+61SChqkzZZt B06wumeK2ext7KCmr7N5mg1UcwrXwVF8ReloEj55JVLgxP2Queul+MzV2MqnhWYrePHq BKPd8uwcQy/jCMrhIZA36oT7k4v8MUQtRCxPfoqMCGsT0rkbwn5Ly+2WyaO3A3ok9890 dUHqOd/bNWN4UMh8PP+szCy28xAl5oPGwP2YOm9SMEVRlaQZczWbuL1ZuJOsm2vLrXNh NlkLfPz6FvAz05PrcZqpldU3Qrl18El0RoL0J8dORteQwr5wuBvwCAkBuHtCjPfZx3tu H24A== X-Gm-Message-State: APzg51CPxN3RF51UI5VvhRSUSdt7ySqFD8g4hU6kyJ1Xwg5zVrebv2qj yH8liu9hZh6n66NTtn9lKHzwBZtekMAvDQwylG3ZRl+6UXvJ+fVJq+d/LftFAIFRD+GlYXPvJlT oLz1BUYQA2CusrlwJLwFrWABxoDtSzRzS66vLX7v5WlrkZNHtKpxERLk= X-Received: by 2002:aca:b48b:: with SMTP id d133-v6mr4250892oif.165.1536793653290; Wed, 12 Sep 2018 16:07:33 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdayqk/F7Xie1GZdQXJQClpgUE3iTh6bCP27XUbYLINOMozPA3gZ42xe36L4B56WsN9yZI1ZR638tS+rtzuNB74= X-Received: by 2002:aca:b48b:: with SMTP id d133-v6mr4250869oif.165.1536793652955; Wed, 12 Sep 2018 16:07:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:28c4:0:0:0:0:0 with HTTP; Wed, 12 Sep 2018 16:07:32 -0700 (PDT) In-Reply-To: References: From: Helena Bales Date: Wed, 12 Sep 2018 16:07:32 -0700 Message-ID: Subject: Re: [discuss] Should we evaluate at commit messages as part of PR review? To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="000000000000c72f870575b4a721" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-12_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809120224 --000000000000c72f870575b4a721 Content-Type: text/plain; charset="UTF-8" I'm a fan of having useful commit messages. I would prefer this to be another checkbox in our list of 6 things to do for Pull Requests as opposed to something that is strictly enforced. There are cases where a simple one-liner commit message is enough. I personally use commit messages often, even when looking back at my own work. Additionally, I think it is a useful exercise as it forces the dev to think back on the original problem and think about how the solution addresses that. tl;dr -- +1 for commit messages ~Helena On Wed, Sep 12, 2018 at 11:50 AM, Pulkit Chandra wrote: > Have we thought about git hooks as a way to enforce policy > https://git-scm.com/book/en/v2/Customizing-Git-An-Example- > Git-Enforced-Policy > ? > > *Pulkit Chandra* > > > On Wed, Sep 12, 2018 at 2:46 PM Alexander Murmann > wrote: > > > Hi everyone, > > > > We have a wiki page > > > > > that discusses why good commit messages matter and links to a even better > > article on the topic. In addition to what's described in those documents, > > better commit messages also would make it easier to have good PR > messages. > > Good commit and PR messages also provide more context to the reviewer who > > in turn now can do a better job at reviewing the pull request. > > > > Looking at our git log gives me the impression that we aren't always > living > > up to that standard. In fact we frequently aren't even close. > > > > I propose taking clear and well formatted commit messages into account as > > part of our PR review process. Lacking commit messages can be just as bad > > as bad naming in our code. > > > > Thoughts? > > > --000000000000c72f870575b4a721--