From dev-return-29588-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Sep 5 01:09:44 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2A7A0180629 for ; Wed, 5 Sep 2018 01:09:42 +0200 (CEST) Received: (qmail 83157 invoked by uid 500); 4 Sep 2018 23:09:42 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 83146 invoked by uid 99); 4 Sep 2018 23:09:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Sep 2018 23:09:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DF5B11A2B09 for ; Tue, 4 Sep 2018 23:09:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.299 X-Spam-Level: * X-Spam-Status: No, score=1.299 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id l70gb-Gn0jvU for ; Tue, 4 Sep 2018 23:09:34 +0000 (UTC) Received: from mx0b-00296801.pphosted.com (mx0b-00296801.pphosted.com [148.163.153.148]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 55D8C5F3F2 for ; Tue, 4 Sep 2018 23:09:34 +0000 (UTC) Received: from pps.filterd (m0114586.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w84N5cgh007057 for ; Tue, 4 Sep 2018 23:09:34 GMT Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by mx0b-00296801.pphosted.com with ESMTP id 2m7m6fb8xk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 04 Sep 2018 23:09:33 +0000 Received: by mail-oi0-f70.google.com with SMTP id y135-v6so6313803oie.11 for ; Tue, 04 Sep 2018 16:09:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=h5iiWbDQWmtstqJekw2wY2pCRxkMSVBjPBMdPvk5fN0=; b=DWv7CwZ7cdrvBVGOFZZ4h7rE8uoflhUJuRXP9BP+AvS8hQNoU7leR9kD7p/Wi8LzXp XZF67vC0e50SxAu3AqAEr2j4eHSDjyf019glWWe4sNENUZFmAAcUGlEkJDY5HzxOD4x5 1KVkOLI7HvINs0dg8M3yrhVO8pFiCIs5l/4wGlSdrB2PH6NJFmsgC6ZKqO5g1hYyCTTJ gdhA+J7wmOdJf8jRXyKqgeILTWlYmLCgkln2FCuFPyrXYOFQLSV4Qx9O3iWYK3hua+fV e+nMxY1YRGlF5XpK5E3Ou54bPLfFZulGTjXT0anogc+g3EkKLfk1e23EwWHWyHYQwhWZ 7g5w== X-Gm-Message-State: APzg51Df84fPpvVg6Ue3TfrG+GM9Yb0VWXb9mSZC9/rmoTtNWM0s5XXm dIbY8KSmt/f7WX2sY/juf7+OuYu3xCt0Ap//2u1tox9hFRbF20FbQRvVmtz6cAZKcTVapCS/eSF mfRLOZUk3FPyo9HkDec3KAIdYpf1wWxa8oUd26qZsl81sIOId461/oQ== X-Received: by 2002:aca:5a45:: with SMTP id o66-v6mr12411489oib.155.1536102572253; Tue, 04 Sep 2018 16:09:32 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ+QoLf2aMkG2Ww/18M/EWcN5Q5EzLQIn4u78EL+KhcLzRAgQXIhoKfJzhWJTvdfXQn2IS8eXZ9lZujiXeVDnY= X-Received: by 2002:aca:5a45:: with SMTP id o66-v6mr12411449oib.155.1536102571598; Tue, 04 Sep 2018 16:09:31 -0700 (PDT) MIME-Version: 1.0 References: <7C0913BA-DFD7-48BC-B012-5CEEE34605AC@pivotal.io> <78a9c054-eeb7-cf42-39d7-ba5e9dc08868@pivotal.io> <518c398a-ac97-be81-424b-16a25881b627@pivotal.io> <4C221A43-3DAD-4E11-9028-9591EC7C95F3@pivotal.io> In-Reply-To: From: Sean Goller Date: Tue, 4 Sep 2018 16:09:19 -0700 Message-ID: Subject: Re: [DISCUSS] Apache Geode 1.7.0 release branch created To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="0000000000001e7dcd057513c058" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-04_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809040230 --0000000000001e7dcd057513c058 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Reverting GEODE-5591 results in code that can produce an infinite loop, so I don't feel that's a viable option. I feel as though the code treats bind exceptions as transient occurrences, but my direct experience with them leads me to the opposite conclusion. I don't believe a long wait time is going to change the situation, especially since a TCP timeout scenario can take up to 30 minutes to resolve itself. I believe it is better to fail fast and hard, so I would suggest either failing immediately or a very short timeout, say 5 or 10 seconds at most. On Tue, Sep 4, 2018 at 4:03 PM Nabarun Nag wrote: > Currently we have a minor issue in the release branch as pointed out by > Barry O. > We will wait till a resolution is figured out for this issue. > > Steps: > 1. create locator > 2. start server --name=3Dserver1 --server-port=3D40404 > 3. start server --name=3Dserver2 --server-port=3D40405 > 4. create gateway-receiver --member=3Dserver1 > 5. create gateway-receiver --member=3Dserver2 `This gets stuck for 2 minu= tes` > > Is the 2 minute wait time acceptable? Should we document it? When we reve= rt > GEODE-5591, this issue does not happen. > > Regards > Nabarun Nag > > On Tue, Sep 4, 2018 at 10:50 AM Nabarun Nag wrote: > > > Status Update on release process for 1.7.0 > > - checkPom files are being modified to have version as 1.7.0 instead of > > 1.8.0-SNAPSHOT > > - gradle.properties file has been modified to reflect 1.7.0 as the > version. > > - Version.java has been reverted to remove all changes corresponding to > > 1.8.0 > > - CommandInitializer.java has been reverted to remove changes for 1.8.0 > > - LuceneIndexCommandsJUnitTest.java has been modified to change > > Version.GEODE_180 to GEODE_170 > > - LuceneIndexCommands.java has been modified to change Version.GEODE_18= 0 > > to GEODE_170 > > -TXCommitMessage.java has been modified to change Version.GEODE_180 to > > GEODE_170 > > > > I will be getting in touch with the individual developers to verify my > > changes. > > The branch will be update once we get a green light on these changes. > > > > Still need updates on these tickets: > > > > GEODE-5600 - [Patrick Rhomberg] > > GEODE-5578 - [Robert Houghton] > > GEODE-5492 - [Robert Houghton] > > GEODE-5280 - [xiaojian zhou & Biju Kunjummen] > > > > These tickets have commits into develop but they are still open with fi= x > > version as 1.8.0 > > > > Regards > > Nabarun Nag > > > > > > > > On Fri, Aug 31, 2018 at 3:38 PM Dale Emery wrote: > > > >> I have resolved GEODE-5254 > >> > >> Dale > >> > >> > On Aug 31, 2018, at 3:34 PM, Nabarun Nag wrote: > >> > > >> > Requesting status update on the following JIRA tickets. These ticket= s > >> have > >> > commits into develop against its name but the status is still open / > >> > unresolved. > >> > > >> > GEODE-5600 - [Patrick Rhomberg] > >> > GEODE-5578 - [Robert Houghton] > >> > GEODE-5492 - [Robert Houghton] > >> > GEODE-5280 - [xiaojian zhou & Biju Kunjummen] > >> > GEODE-5254 - [Dale Emery] > >> > > >> > GEODE-4794 - [Sai] > >> > GEODE-5594 - [Sai] > >> > > >> > Regards > >> > Nabarun Nag > >> > > >> > > >> > On Fri, Aug 31, 2018 at 3:18 PM Nabarun Nag wrote: > >> > > >> >> > >> >> Please continue using 1.7.0 as a fix version in JIRA till the email > >> comes > >> >> in that the 1.7.0 release branch has be cut. > >> >> > >> >> Changing the fixed version for the following tickets to 1.7.0 from > >> 1.8.0 > >> >> as these fixes will be included in the 1.7.0 release > >> >> > >> >> GEODE-5671 > >> >> GEODE-5662 > >> >> GEODE-5660 > >> >> GEODE-5652 > >> >> > >> >> Regards > >> >> Nabarun Nag > >> >> > >> >> > >> >> On Fri, Aug 31, 2018 at 2:20 PM Nabarun Nag wrote= : > >> >> > >> >>> A new feature of get/set cluster config was added as new feature t= o > >> gfsh. > >> >>> This needs to be added to the documentation. > >> >>> Once this is done, the branch will be ready. > >> >>> > >> >>> Regards > >> >>> Nabarun > >> >>> > >> >>> > >> >>> On Fri, Aug 31, 2018 at 2:15 PM Alexander Murmann < > >> amurmann@pivotal.io> > >> >>> wrote: > >> >>> > >> >>>> Nabarun, do you still see anything blocking cutting the release a= t > >> this > >> >>>> point? > >> >>>> > >> >>>> Maybe we can even get a pipeline going today? =F0=9F=98=B3 > >> >>>> > >> >>>> On Fri, Aug 31, 2018 at 10:38 AM, Sai Boorlagadda < > >> >>>> sai.boorlagadda@gmail.com > >> >>>>> wrote: > >> >>>> > >> >>>>> We can go ahead and cut 1.7 with out GEODE-5338 as I don't have > the > >> >>>> code > >> >>>>> ready. > >> >>>>> > >> >>>>> GEODE-5594, adds a new flag to enable hostname validation and is > >> >>>> disabled > >> >>>>> by default so we are good with changes that are already merged a= nd > >> >>>>> documentation for GEODE-5594 is ready merged. > >> >>>>> > >> >>>>> Naba, after the branch is cut we should delete windows jobs from > the > >> >>>> branch > >> >>>>> before we create the pipeline for 1.7. > >> >>>>> > >> >>>>> Apologies for holding up the release. > >> >>>>> > >> >>>>> Sai. > >> >>>>> > >> >>>>> On Fri, Aug 31, 2018, 10:23 AM Nabarun Nag > wrote: > >> >>>>> > >> >>>>>> I am waiting on the documentation tickets to get closed before > >> >>>> cutting > >> >>>>> the > >> >>>>>> branch. > >> >>>>>> > >> >>>>>> Regards > >> >>>>>> Nabarun Nag > >> >>>>>> > >> >>>>>> On Fri, Aug 31, 2018 at 10:18 AM Anthony Baker < > abaker@pivotal.io> > >> >>>>> wrote: > >> >>>>>> > >> >>>>>>> Perhaps we should cut 1.7.0 without these changes to give us > more > >> >>>> time > >> >>>>> to > >> >>>>>>> review and complete the work. > >> >>>>>>> > >> >>>>>>> Thoughts? > >> >>>>>>> > >> >>>>>>> Anthony > >> >>>>>>> > >> >>>>>>> > >> >>>>>>>> On Aug 31, 2018, at 8:03 AM, Sai Boorlagadda < > >> >>>>>> sai.boorlagadda@gmail.com> > >> >>>>>>> wrote: > >> >>>>>>>> > >> >>>>>>>> I haven't yet merged GEODE-5338. The PR changes the existing > >> >>>> behavior > >> >>>>>> and > >> >>>>>>>> is not acceptable. > >> >>>>>>>> Working on changing the implementation to have a default valu= e > >> >>>>> derived > >> >>>>>>>> based on how user > >> >>>>>>>> wants to configure SSL. > >> >>>>>>>> > >> >>>>>>>> Sai > >> >>>>>>>> > >> >>>>>>>> On Wed, Aug 29, 2018 at 11:45 AM Sai Boorlagadda < > >> >>>>>>> sai.boorlagadda@gmail.com> > >> >>>>>>>> wrote: > >> >>>>>>>> > >> >>>>>>>>> I have merged GEODE-5594 to develop. > >> >>>>>>>>> > >> >>>>>>>>> GEODE-5338 is now waiting for PR review and precheckin. > >> >>>>>>>>> > >> >>>>>>>>> Sai > >> >>>>>>>>> > >> >>>>>>>>> On Tue, Aug 28, 2018 at 10:30 AM Sai Boorlagadda < > >> >>>>>>>>> sai.boorlagadda@gmail.com> wrote: > >> >>>>>>>>> > >> >>>>>>>>>> GEODE-5338 is downvoted for the security concerns related t= o > >> >>>>> trusting > >> >>>>>>>>>> the default trust store and thus resulted in an improvement > to > >> >>>> add > >> >>>>> a > >> >>>>>>>>>> hostname > >> >>>>>>>>>> validation as a feature before we can support trusting > default > >> >>>>> trust > >> >>>>>>>>>> store. > >> >>>>>>>>>> > >> >>>>>>>>>> So GEODE-5338 is blocked by GEODE-5594. > >> >>>>>>>>>> > >> >>>>>>>>>> Once I merge GEODE-5594, I will reinitiate review on > >> >>>> GEODE-5338 PR. > >> >>>>>>>>>> > >> >>>>>>>>>> Sai > >> >>>>>>>>>> > >> >>>>>>>>>> On Tue, Aug 28, 2018 at 10:15 AM Alexander Murmann < > >> >>>>>>> amurmann@pivotal.io> > >> >>>>>>>>>> wrote: > >> >>>>>>>>>> > >> >>>>>>>>>>> Looks like we are now waiting for these tickets: > >> >>>>>>>>>>> > >> >>>>>>>>>>> GEODE-5601 which is a dup of GEODE-5590 which has this ope= n > >> >>>> PR: > >> >>>>>>>>>>> https://github.com/apache/geode/pull/2368. > >> >>>>>>>>>>> GEODE-5594 has open PR: > >> >>>> https://github.com/apache/geode/pull/2346 > >> >>>>>>>>>>> GEODE-5338 < > >> >>>> https://github.com/apache/geode/pull/2346GEODE-5338> > >> >>>>>> has > >> >>>>>>>>>>> open PR: https://github.com/apache/geode/pull/2244. > >> >>>>>>>>>>> > >> >>>>>>>>>>> Does this look right? > >> >>>>>>>>>>> > >> >>>>>>>>>>> The GEODE-5338 ticket is the most concerning to me right > now. > >> >>>> The > >> >>>>> PR > >> >>>>>>> was > >> >>>>>>>>>>> down voted, had some down voted discussion and nothing > since. > >> >>>> Sai > >> >>>>>>>>>>> mentioned > >> >>>>>>>>>>> yesterday that this might be able to merge. That's > surprising > >> >>>>> given > >> >>>>>>> the > >> >>>>>>>>>>> downvotes and lack of discussion. Sai, do you want to give > us > >> >>>> a > >> >>>>>>> update, > >> >>>>>>>>>>> maybe on the PR? > >> >>>>>>>>>>> > >> >>>>>>>>>>> On Tue, Aug 28, 2018 at 1:31 AM, Juan Jos=C3=A9 Ramos < > >> >>>>> jramos@pivotal.io > >> >>>>>>> > >> >>>>>>>>>>> wrote: > >> >>>>>>>>>>> > >> >>>>>>>>>>>> Thanks!! > >> >>>>>>>>>>>> > >> >>>>>>>>>>>> On Tue, Aug 28, 2018 at 9:13 AM Nabarun Nag < > nnag@apache.org > >> >>>>> > >> >>>>>> wrote: > >> >>>>>>>>>>>> > >> >>>>>>>>>>>>> Hi Juan, > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>>> GEODE-5618 as PR#2360 has been merged in to develop. The > new > >> >>>>>> branch > >> >>>>>>>>>>> has > >> >>>>>>>>>>>> not > >> >>>>>>>>>>>>> yet been created hence this fix will be in 1.7.0 > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>>> Regards > >> >>>>>>>>>>>>> Nabarun Nag > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>>> On Tue, Aug 28, 2018 at 12:33 AM Juan Jos=C3=A9 Ramos < > >> >>>>>> jramos@pivotal.io > >> >>>>>>>> > >> >>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>>>> Hello team, > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> Can we also include GEODE-5618 in the next release?. Th= e > >> >>>> pull > >> >>>>>>>>>>> request > >> >>>>>>>>>>>> has > >> >>>>>>>>>>>>>> been approved already, it just needs to be merged. > >> >>>>>>>>>>>>>> Best regards. > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> On Mon, Aug 27, 2018 at 11:45 PM Bruce Schuchardt < > >> >>>>>>>>>>>>> bschuchardt@pivotal.io> > >> >>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> great! thanks > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> On 8/27/18 1:42 PM, Nabarun Nag wrote: > >> >>>>>>>>>>>>>>>> I completely agree. Once the branch is created, it wi= ll > >> >>>>>>>>>>> undergo all > >> >>>>>>>>>>>>>>>> compatibility and upgrade tests. > >> >>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>> The commit that you have mentioned will be reverted i= n > >> >>>> 1.7.0, > >> >>>>>>>>>>> as > >> >>>>>>>>>>>> well > >> >>>>>>>>>>>>>> as > >> >>>>>>>>>>>>>>>> any related commits > >> >>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>> Regards > >> >>>>>>>>>>>>>>>> Nabarun Nag > >> >>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>> On Mon, Aug 27, 2018 at 1:34 PM Bruce Schuchardt < > >> >>>>>>>>>>>>>> bschuchardt@pivotal.io > >> >>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>> I don't think it's as easy as doing a rebase. Someo= ne > >> >>>> added > >> >>>>>>>>>>> the > >> >>>>>>>>>>>> 1.8 > >> >>>>>>>>>>>>>>>>> version to Version.java and we need to revert that. > We > >> >>>> also > >> >>>>>>>>>>> need > >> >>>>>>>>>>>> to > >> >>>>>>>>>>>>>> see > >> >>>>>>>>>>>>>>>>> if it's being used anywhere for > >> >>>> backward-compatibility. If > >> >>>>>>>>>>> it's > >> >>>>>>>>>>>> in > >> >>>>>>>>>>>>>> use > >> >>>>>>>>>>>>>>>>> those changes need to be examined and probably undon= e > >> >>>> on the > >> >>>>>>>>>>>> branch > >> >>>>>>>>>>>>> if > >> >>>>>>>>>>>>>>>>> they're targeting 1.7 peers/clients. > >> >>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>> On 8/27/18 12:11 PM, Nabarun Nag wrote: > >> >>>>>>>>>>>>>>>>>> @Bruce those changes were done when 1.7.0 release > >> >>>> process > >> >>>>> was > >> >>>>>>>>>>>>>>>>> in-progress, > >> >>>>>>>>>>>>>>>>>> and a release branch was already created. But we > >> >>>> stopped > >> >>>>> that > >> >>>>>>>>>>>>> process > >> >>>>>>>>>>>>>>> mid > >> >>>>>>>>>>>>>>>>>> way. This happened in May 2018. > >> >>>>>>>>>>>>>>>>>> We are planning to rebase the 1.7.0 brach with the > >> >>>> current > >> >>>>>>>>>>>> develop > >> >>>>>>>>>>>>>>> pretty > >> >>>>>>>>>>>>>>>>>> soon. > >> >>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>> Regards > >> >>>>>>>>>>>>>>>>>> Nabarun > >> >>>>>>>>>>>>>>>>>> On Mon, Aug 27, 2018 at 12:02 PM Bruce Schuchardt < > >> >>>>>>>>>>>>>>>>> bschuchardt@pivotal.io> > >> >>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> It looks like we've cut a 1.7.0 release branch tha= t > >> >>>> says > >> >>>>> its > >> >>>>>>>>>>>>> 1.8.0. > >> >>>>>>>>>>>>>>> Is > >> >>>>>>>>>>>>>>>>>>> that intentional? > >> >>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> private static final byte GEODE_180_ORDINAL =3D95; > >> >>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> public static final VersionGEODE_180 =3D > >> >>>>>>>>>>>>>>>>>>> new Version("GEODE","1.8.0", (byte)1, (byte)8= , > >> >>>>>>>>>>> (byte)0, > >> >>>>>>>>>>>>>>>>>>> (byte)0,GEODE_180_ORDINAL); > >> >>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> On 8/27/18 9:50 AM, Sai Boorlagadda wrote: > >> >>>>>>>>>>>>>>>>>>>> After reading through the weekend, validating > >> >>>> against CN > >> >>>>>>>>>>> as a > >> >>>>>>>>>>>>>>>>>>>> fallback should be acceptable and dont have any > >> >>>> further > >> >>>>>>>>>>>> concerns > >> >>>>>>>>>>>>>>>>>>>> with default JDK's implementation as expressed[1]= . > >> >>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>> Planning to merge GEODE-5594 today and following > with > >> >>>>>>>>>>>> GEODE-5338. > >> >>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>> Sai > >> >>>>>>>>>>>>>>>>>>>> [1] > >> >>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>> > >> >>>>>> > >> https://lists.apache.org/thread.html/906540e18fa6f85fc77c88c28fc74a > >> >>>>>>>>>>>> 61402471d2eed4ee9dab4813c9@%3Cdev.geode.apache.org%3E > >> >>>>>>>>>>>>>>>>>>>> On Fri, Aug 24, 2018 at 5:07 PM Sai Boorlagadda < > >> >>>>>>>>>>>>>>>>>>> sai.boorlagadda@gmail.com> > >> >>>>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>> Regarding GEODE-5594, though the current > >> >>>> implementation > >> >>>>> is > >> >>>>>>>>>>>> good > >> >>>>>>>>>>>>>> and > >> >>>>>>>>>>>>>>>>>>> needed > >> >>>>>>>>>>>>>>>>>>>>> more coverage. > >> >>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>> While adding tests to cover negative cases, I > found > >> >>>>>>>>>>> something > >> >>>>>>>>>>>>>> about > >> >>>>>>>>>>>>>>>>>>> JDK's > >> >>>>>>>>>>>>>>>>>>>>> default implementation of > >> >>>>>>>>>>>>>>>>>>>>> hostname validation which I am not happy about a= nd > >> >>>> so it > >> >>>>>>>>>>>> needs a > >> >>>>>>>>>>>>>>>>>>>>> rethought. It could result in > >> >>>>>>>>>>>>>>>>>>>>> implementing our own custom algorithm to do > hostname > >> >>>>>>>>>>>> validation. > >> >>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>> I will send out details and seek to advise on wh= at > >> >>>> we > >> >>>>>>>>>>> should > >> >>>>>>>>>>>> do > >> >>>>>>>>>>>>>> in a > >> >>>>>>>>>>>>>>>>>>>>> different thread. > >> >>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>> Sai > >> >>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>> On Fri, Aug 24, 2018 at 10:52 AM Alexander > Murmann < > >> >>>>>>>>>>>>>>>>> amurmann@pivotal.io > >> >>>>>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>> To summarize where we are right now in this > >> >>>> discussion, > >> >>>>>>>>>>> I see > >> >>>>>>>>>>>>> the > >> >>>>>>>>>>>>>>>>>>>>>> following > >> >>>>>>>>>>>>>>>>>>>>>> tickets listed in this thread as want-to-haves > for > >> >>>> 1.7: > >> >>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>> - GEODE-5615 - =E2=9C=85 resolved > >> >>>>>>>>>>>>>>>>>>>>>> - GEODE-5601 - =F0=9F=8F=83=E2=80=8D=E2=99= =80=EF=B8=8F in progress > >> >>>>>>>>>>>>>>>>>>>>>> - GEODE-5594 - =F0=9F=8F=83=E2=80=8D=E2=99= =80=EF=B8=8F waiting for PR review > >> >>>>>>>>>>>>>>>>>>>>>> - GEODE-5338 - =F0=9F=8F=83=E2=80=8D=E2=99= =80=EF=B8=8F waiting for PR review > >> >>>>>>>>>>>>>>>>>>>>>> - GEODE-5619 - =F0=9F=99=84 in progress in = JIRA but has > >> >>>>>>>>>>> merged > >> >>>>>>>>>>>> PR. > >> >>>>>>>>>>>>>> What > >> >>>>>>>>>>>>>>>>> does > >> >>>>>>>>>>>>>>>>>>> it > >> >>>>>>>>>>>>>>>>>>>>>> mean? > >> >>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>> Is there anything else that needs to go into 1.= 7? > >> >>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>> It seems like the best we all can do is to revi= ew > >> >>>> Sai's > >> >>>>>>>>>>> PRs. > >> >>>>>>>>>>>> Is > >> >>>>>>>>>>>>>>> that > >> >>>>>>>>>>>>>>>>>>>>>> correct? > >> >>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>> On Wed, Aug 22, 2018 at 10:59 AM, Jens Deppe < > >> >>>>>>>>>>>>> jdeppe@pivotal.io> > >> >>>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>>>>> I'd also like to include GEODE-5619 > >> >>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>> On Tue, Aug 21, 2018 at 3:59 PM Xiaojian Zhou = < > >> >>>>>>>>>>>>> gzhou@pivotal.io > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>>>>>> +1 > >> >>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>> The release will be a great one with so many > >> >>>>> historical > >> >>>>>>>>>>>> bugs > >> >>>>>>>>>>>>>>> fixed. > >> >>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>> Today I tried to use IJ to build and run with > >> >>>> latest > >> >>>>>>>>>>>>>> build.gradle > >> >>>>>>>>>>>>>>>>> and > >> >>>>>>>>>>>>>>>>>>>>>>>> recent moved test packages, it worked. So thi= s > >> >>>>>>>>>>> refactoring > >> >>>>>>>>>>>> is > >> >>>>>>>>>>>>>>> also > >> >>>>>>>>>>>>>>>>>>>>>>> success. > >> >>>>>>>>>>>>>>>>>>>>>>>> On Tue, Aug 21, 2018 at 3:52 PM, Anthony Bake= r > < > >> >>>>>>>>>>>>>>> abaker@pivotal.io> > >> >>>>>>>>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>>>>>>> I most definitely agree! > >> >>>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>>> Anthony > >> >>>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>>>> On Aug 21, 2018, at 2:26 PM, Dan Smith < > >> >>>>>>>>>>>> dsmith@pivotal.io> > >> >>>>>>>>>>>>>>>>> wrote: > >> >>>>>>>>>>>>>>>>>>>>>>>>>> I think we do want to wait for GEODE-5615 > >> >>>>>>>>>>>> (DistributedTest > >> >>>>>>>>>>>>>>> OOMEs) > >> >>>>>>>>>>>>>>>>>>>>>> and > >> >>>>>>>>>>>>>>>>>>>>>>>>>> GEODE-5601 (AcceptanceTest port conflicts) = to > >> >>>> be > >> >>>>>>>>>>> fixed > >> >>>>>>>>>>>>> before > >> >>>>>>>>>>>>>>>>>>>>>> cutting > >> >>>>>>>>>>>>>>>>>>>>>>>> the > >> >>>>>>>>>>>>>>>>>>>>>>>>>> new 1.7 branch. It would be better if we > don't > >> >>>>>>>>>>> create a > >> >>>>>>>>>>>>>> release > >> >>>>>>>>>>>>>>>>>>>>>>> branch > >> >>>>>>>>>>>>>>>>>>>>>>>>> from > >> >>>>>>>>>>>>>>>>>>>>>>>>>> a point where we have these systematic issu= es > >> >>>> with > >> >>>>>>>>>>> our > >> >>>>>>>>>>>>>>> pipeline. > >> >>>>>>>>>>>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>>>>>>>>>>>>> -Dan > >> >>>>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> -- > >> >>>>>>>>>>>>>> Juan Jos=C3=A9 Ramos Cassella > >> >>>>>>>>>>>>>> Senior Technical Support Engineer > >> >>>>>>>>>>>>>> Email: jramos@pivotal.io > >> >>>>>>>>>>>>>> Office#: +353 21 4238611 <+353%2021%20423%208611> > >> <+353%2021%20423%208611> > >> >>>> <+353%2021%20423%208611> > >> >>>>>>> <+353%2021%20423%208611> > >> >>>>>>>>>>>>>> Mobile#: +353 87 2074066 <+353%2087%20207%204066> > >> <+353%2087%20207%204066> > >> >>>> <+353%2087%20207%204066> > >> >>>>>>> <+353%2087%20207%204066> > >> >>>>>>>>>>>>>> After Hours Contact#: +1 877 477 2269 <(877)%20477-2269= > > >> <(877)%20477-2269> > >> >>>> <(877)%20477-2269> > >> >>>>>>> <(877)%20477-2269> > >> >>>>>>>>>>>>>> Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - > >> >>>> 16:00 > >> >>>>> GMT > >> >>>>>>>>>>>>>> How to upload artifacts: > >> >>>>>>>>>>>>>> https://support.pivotal.io/hc/en-us/articles/204369073 > >> >>>>>>>>>>>>>> How to escalate a ticket: > >> >>>>>>>>>>>>>> https://support.pivotal.io/hc/en-us/articles/203809556 > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> [image: support] [image: > >> >>>>> twitter] > >> >>>>>>>>>>>>>> [image: linkedin] > >> >>>>>>>>>>>>>> [image: > >> >>>> facebook] > >> >>>>>>>>>>>>>> [image: > google > >> >>>>> plus] > >> >>>>>>>>>>>>>> [image: youtube] > >> >>>>>>>>>>>>>> < > >> >>>>>>>>>>>>> > >> >>>>>>>>>>> > >> >>>>>>> https://www.youtube.com/playlist?list=3DPLAdzTan_ > >> >>>>> eSPScpj2J50ErtzR9ANSzv3kl > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>> > >> >>>>>>>>>>>> > >> >>>>>>>>>>>> > >> >>>>>>>>>>>> -- > >> >>>>>>>>>>>> Juan Jos=C3=A9 Ramos Cassella > >> >>>>>>>>>>>> Senior Technical Support Engineer > >> >>>>>>>>>>>> Email: jramos@pivotal.io > >> >>>>>>>>>>>> Office#: +353 21 4238611 <+353%2021%20423%208611> > >> <+353%2021%20423%208611> > >> >>>> <+353%2021%20423%208611> > >> >>>>>>>>>>>> Mobile#: +353 87 2074066 <+353%2087%20207%204066> > >> <+353%2087%20207%204066> > >> >>>> <+353%2087%20207%204066> > >> >>>>>>>>>>>> After Hours Contact#: +1 877 477 2269 <(877)%20477-2269> > >> <(877)%20477-2269> > >> >>>> <(877)%20477-2269> > >> >>>>>>>>>>>> Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - > 16:00 > >> >>>> GMT > >> >>>>>>>>>>>> How to upload artifacts: > >> >>>>>>>>>>>> https://support.pivotal.io/hc/en-us/articles/204369073 > >> >>>>>>>>>>>> How to escalate a ticket: > >> >>>>>>>>>>>> https://support.pivotal.io/hc/en-us/articles/203809556 > >> >>>>>>>>>>>> > >> >>>>>>>>>>>> [image: support] [image: > >> >>>> twitter] > >> >>>>>>>>>>>> [image: linkedin] > >> >>>>>>>>>>>> [image: > facebook] > >> >>>>>>>>>>>> [image: google > >> >>>> plus] > >> >>>>>>>>>>>> [image: youtube] > >> >>>>>>>>>>>> < > >> >>>>>>>>>>> > >> >>>>>>> https://www.youtube.com/playlist?list=3DPLAdzTan_ > >> >>>>> eSPScpj2J50ErtzR9ANSzv3kl > >> >>>>>>>>>>>> > >> >>>>>>>>>>>> > >> >>>>>>>>>>> > >> >>>>>>>>>> > >> >>>>>>> > >> >>>>>>> > >> >>>>>> > >> >>>>> > >> >>>> > >> >>> > >> > >> > --0000000000001e7dcd057513c058--