From dev-return-29603-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Sep 5 18:41:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 88868180654 for ; Wed, 5 Sep 2018 18:41:18 +0200 (CEST) Received: (qmail 45056 invoked by uid 500); 5 Sep 2018 16:41:12 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 45045 invoked by uid 99); 5 Sep 2018 16:41:12 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 16:41:12 +0000 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 869A8D27 for ; Wed, 5 Sep 2018 16:41:11 +0000 (UTC) Received: by mail-lj1-f197.google.com with SMTP id q13-v6so1691380ljj.4 for ; Wed, 05 Sep 2018 09:41:11 -0700 (PDT) X-Gm-Message-State: APzg51CscCTm1fDh3QIYMy3pVzd3AUqwpSVnHIOy1K3kXrhgaoMisbhx bbbaEjqBmO55+niaZ0DQPmRFqOpMtkg8LqAB6I6MWmLTgPJlMVxm9DvsEv9bXfAQDp+9wBWKyUD afpuDPobHkt7lj68fg3xqtMfmxC6sZj8K9Hw3ZjU4NXb1Xx/VIAd3lBM= X-Received: by 2002:a2e:2096:: with SMTP id g22-v6mr24102872lji.37.1536165670023; Wed, 05 Sep 2018 09:41:10 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb32KjcWSQHLMYzLstSWNrBBiipDl0SSuljpP1oUE/X5VNt97Q9orQQrk1mvmrEMrUtBVtbS17oOdDDahyZCvU= X-Received: by 2002:a2e:2096:: with SMTP id g22-v6mr24102866lji.37.1536165669945; Wed, 05 Sep 2018 09:41:09 -0700 (PDT) MIME-Version: 1.0 References: <382ffe87-c43c-a1cf-a953-62a9e5079855@pivotal.io> In-Reply-To: From: Nabarun Nag Date: Wed, 5 Sep 2018 09:40:58 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 2 minute gateway startup time due to GEODE-5591 To: dev@geode.apache.org Content-Type: multipart/alternative; boundary="00000000000012da0d0575227192" --00000000000012da0d0575227192 Content-Type: text/plain; charset="UTF-8" If everyone is okay with it, I will revert that change in develop and then cherry pick it to release/1.7.0 branch. Please do comment. Regards Nabarun Nag On Wed, Sep 5, 2018 at 9:30 AM Dan Smith wrote: > +1 to yank it and rework the fix. > > Gester's change helps, but it just means that you will sometimes randomly > have a 2 minute delay starting up a gateway receiver. I don't think that is > a great user experience either. > > -Dan > > On Wed, Sep 5, 2018 at 8:20 AM, Bruce Schuchardt > wrote: > > > Let's yank it > > > > > > > > On 9/4/18 5:04 PM, Sean Goller wrote: > > > >> If it's to get the release out, I'm fine with reverting. I don't like > it, > >> but I'm not willing to die on that hill. :) > >> > >> -S. > >> > >> On Tue, Sep 4, 2018 at 4:38 PM Dan Smith wrote: > >> > >> Spitting this into a separate thread. > >>> > >>> I see the issue. The two minute timeout is the constructor for > >>> AcceptorImpl, where it retries to bind for 2 minutes. > >>> > >>> That behavior makes sense for CacheServer.start. > >>> > >>> But it doesn't make sense for the new logic in GatewayReceiver.start() > >>> from > >>> GEODE-5591. That code is trying to use CacheServer.start to scan for an > >>> available port, trying each port in a range. That free port finding > logic > >>> really doesn't want to have two minutes of retries for each port. It > >>> seems > >>> like we need to rework the fix for GEODE-5591. > >>> > >>> Does it make sense to hold up the release to rework this fix, or should > >>> we > >>> just revert it? Have we switched concourse over to using alpine linux, > >>> which I think was the original motivation for this fix? > >>> > >>> -Dan > >>> > >>> On Tue, Sep 4, 2018 at 4:25 PM, Dan Smith wrote: > >>> > >>> Why is it waiting at all in this case? Where is this 2 minute timeout > >>>> coming from? > >>>> > >>>> -Dan > >>>> > >>>> On Tue, Sep 4, 2018 at 4:12 PM, Sai Boorlagadda < > >>>> > >>> sai.boorlagadda@gmail.com > >>> > >>>> wrote: > >>>>> So the issue is that it takes longer to start than previous releases? > >>>>> Also, is this wait time only when using Gfsh to create > >>>>> gateway-receiver? > >>>>> > >>>>> On Tue, Sep 4, 2018 at 4:03 PM Nabarun Nag wrote: > >>>>> > >>>>> Currently we have a minor issue in the release branch as pointed out > >>>>>> > >>>>> by > >>> > >>>> Barry O. > >>>>>> We will wait till a resolution is figured out for this issue. > >>>>>> > >>>>>> Steps: > >>>>>> 1. create locator > >>>>>> 2. start server --name=server1 --server-port=40404 > >>>>>> 3. start server --name=server2 --server-port=40405 > >>>>>> 4. create gateway-receiver --member=server1 > >>>>>> 5. create gateway-receiver --member=server2 `This gets stuck for 2 > >>>>>> > >>>>> minutes` > >>>>> > >>>>>> Is the 2 minute wait time acceptable? Should we document it? When we > >>>>>> > >>>>> revert > >>>>> > >>>>>> GEODE-5591, this issue does not happen. > >>>>>> > >>>>>> Regards > >>>>>> Nabarun Nag > >>>>>> > >>>>>> > > > --00000000000012da0d0575227192--