From dev-return-29763-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Sep 19 23:29:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C4B5F180621 for ; Wed, 19 Sep 2018 23:29:20 +0200 (CEST) Received: (qmail 63592 invoked by uid 500); 19 Sep 2018 21:29:19 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 63581 invoked by uid 99); 19 Sep 2018 21:29:19 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2018 21:29:19 +0000 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id DD67F2B82 for ; Wed, 19 Sep 2018 21:29:18 +0000 (UTC) Received: by mail-lf1-f72.google.com with SMTP id e4-v6so1893809lfc.19 for ; Wed, 19 Sep 2018 14:29:18 -0700 (PDT) X-Gm-Message-State: APzg51CD0Jn/IVh/TMHngbHRzctU7Jsx/vcqTPFW40HsnkydCeng/4iI ZQdTHox4pVZKvYaZQvw0DIPVY/1tgitJhbc3wRSpX15WTRZhZ9h8o6BgZixD/egt5uY9lRSX9EE L9IQXiIyWrRmGbjgABTWH5eChRBp3BD4aKrp5/YXh/6aGMRQOCmF5BzI= X-Received: by 2002:a19:12a5:: with SMTP id 37-v6mr18185573lfs.51.1537392557495; Wed, 19 Sep 2018 14:29:17 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYTQP+NjKrhv1q74cU9cYzNMOmSlOWTW2OfxqKPQjwSrA9mGTe268Z/KIcxilK6NWfHoinGLKHJUhVDT1cudzw= X-Received: by 2002:a19:12a5:: with SMTP id 37-v6mr18185569lfs.51.1537392557299; Wed, 19 Sep 2018 14:29:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:920e:0:0:0:0:0 with HTTP; Wed, 19 Sep 2018 14:29:16 -0700 (PDT) From: Kirk Lund Date: Wed, 19 Sep 2018 14:29:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Adding new dependencies To: geode Content-Type: multipart/alternative; boundary="000000000000423551057640190c" --000000000000423551057640190c Content-Type: text/plain; charset="UTF-8" Please be extra careful when adding new dependencies. Our build is setup to allow transitive dependencies, so reviews should include looking at the tree of transitive dependencies that a new dependency pulls into Geode. I think it would also be a good idea to create a little extra noise on the dev-list about the new dependency before you file a PR that adds it. Maybe, explain what the dependency is, how it'll be used, whether or not it's part of the distro, what transitive dependencies it might pull in, etc. Thanks, Kirk --000000000000423551057640190c--