geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@apache.org>
Subject Re: Steps to follow after becoming a Geode committer
Date Tue, 18 Sep 2018 16:51:36 GMT
I reviewed your changes and added approval. Thanks Juan!

On Tue, Sep 18, 2018 at 12:46 AM, Juan José Ramos <jramos@pivotal.io> wrote:

> Hello Jinmei and Dan,
>
> Thanks both for the reply!!.
> Regarding pull 2250, I think the changes requested by Galen are outdated
> now, but I'll ping him directly in the *pull request * anyway to be sure.
> Best regards.
>
>
> On Mon, Sep 17, 2018 at 5:37 PM Dan Smith <dsmith@pivotal.io> wrote:
>
> > Hi Juan,
> >
> > Great questions! I agree with what Jinmei said - go ahead and merge if
> you
> > have:
> >
> > 1) at least one approval
> > 2) No changes requested
> > 3) Checks are passing
> >
> > The "at least one review" part is somewhat subjective, if you feel the PR
> > is complicated and you want more reviews, feel free to ask the list for
> > more feedback.
> >
> > I see https://github.com/apache/geode/pull/2250 has one reviewer
> > requesting
> > changes. You should look into the suggestions, or maybe just poke Galen
> if
> > he needs to review your fixes and approve them?
> >
> > -Dan
> >
> > On Mon, Sep 17, 2018 at 6:45 AM, Jinmei Liao <jiliao@pivotal.io> wrote:
> >
> > > I believe you can go ahead. :-)
> > >
> > > The way I see it, you can merge a PR when all three are satisfied:
> > > 1) you have the privilege to merge it (the button is activated for you
> to
> > > push).
> > > 2) The PR is approved by a least one reviewer.
> > > 3) all checks passed.
> > >
> > > Thanks!
> > >
> > >
> > > On Mon, Sep 17, 2018, 3:48 AM Ju@N <jujoramos@gmail.com> wrote:
> > >
> > > > Hello all,
> > > >
> > > > My apache account is already created and everything seems to be
> working
> > > > just fine, I've already linked my account through
> > > > https://gitbox.apache.org/setup/ and I can see the option *Merge
> pull
> > > > request* in the *GitHub* interface (disabled in the past when I
> didn't
> > > have
> > > > commit privileges on the project).
> > > > I have two old pull requests (2376
> > > > <https://github.com/apache/geode/pull/2376> for GEODE-5353
> > > > <https://issues.apache.org/jira/browse/GEODE-5353> and 2250
> > > > <https://github.com/apache/geode/pull/2250> for GEODE-5314
> > > > <https://issues.apache.org/jira/browse/GEODE-5314>) already approved
> > by
> > > > other committers, am I ready to go and merge them myself?, or should
> I
> > > wait
> > > > for an announcement or something else?. I've already gone through
> > > Becoming
> > > > a Committer
> > > > <
> > https://cwiki.apache.org/confluence/display/GEODE/Becoming+a+committer>
> > > >  and Code Contributions
> > > > <https://cwiki.apache.org/confluence/display/GEODE/Code+
> contributions>
> > > but
> > > > couldn't find a definitive answer about how/when to merge a *pull
> > > > request* opened
> > > > by yourself when you're a committer, how does this process work?,
> > should
> > > I
> > > > ask in this list for reviews before merging the changes?, should I
> > wait X
> > > > amount of days before asking for reviewers?, etc.
> > > > As a side note, I've received an email from *root@apache.org
> > > > <root@apache.org>* with a link to the vote reference in the
> > > > *private.apache.geode.org
> > > > <http://private.apache.geode.org/>* list. I believe that list is
> only
> > > for
> > > > *PMC* members, so I don't (and won't) have access to that list, am I
> > > > right?.
> > > > Sorry for the long email and the amount of questions, just trying to
> > make
> > > > sure I get things right from the very beginning :-).
> > > > Best regards.
> > > >
> > > > --
> > > > Ju@N
> > > >
> > >
> >
>
>
> --
> Juan José Ramos Cassella
> Senior Technical Support Engineer
> Email: jramos@pivotal.io
> Office#: +353 21 4238611
> Mobile#: +353 87 2074066
> After Hours Contact#: +1 877 477 2269
> Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - 16:00 GMT
> How to upload artifacts:
> https://support.pivotal.io/hc/en-us/articles/204369073
> How to escalate a ticket:
> https://support.pivotal.io/hc/en-us/articles/203809556
>
> [image: support] <https://support.pivotal.io/> [image: twitter]
> <https://twitter.com/pivotal> [image: linkedin]
> <https://www.linkedin.com/company/3048967> [image: facebook]
> <https://www.facebook.com/pivotalsoftware> [image: google plus]
> <https://plus.google.com/+Pivotal> [image: youtube]
> <https://www.youtube.com/playlist?list=PLAdzTan_eSPScpj2J50ErtzR9ANSzv3kl>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message