geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pulkit Chandra <pchan...@pivotal.io>
Subject Re: [discuss] Should we evaluate at commit messages as part of PR review?
Date Wed, 12 Sep 2018 18:50:41 GMT
Have we thought about git hooks as a way to enforce policy
https://git-scm.com/book/en/v2/Customizing-Git-An-Example-Git-Enforced-Policy
?

*Pulkit Chandra*


On Wed, Sep 12, 2018 at 2:46 PM Alexander Murmann <amurmann@pivotal.io>
wrote:

> Hi everyone,
>
> We have a wiki page
> <https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format>
> that discusses why good commit messages matter and links to a even better
> article on the topic. In addition to what's described in those documents,
> better commit messages also would make it easier to have good PR messages.
> Good commit and PR messages also provide more context to the reviewer who
> in turn now can do a better job at reviewing the pull request.
>
> Looking at our git log gives me the impression that we aren't always living
> up to that standard. In fact we frequently aren't even close.
>
> I propose taking clear and well formatted commit messages into account as
> part of our PR review process. Lacking commit messages can be just as bad
> as bad naming in our code.
>
> Thoughts?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message