From dev-return-29470-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Aug 22 18:28:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB39A180662 for ; Wed, 22 Aug 2018 18:28:10 +0200 (CEST) Received: (qmail 29435 invoked by uid 500); 22 Aug 2018 16:28:09 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 29424 invoked by uid 99); 22 Aug 2018 16:28:09 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 16:28:09 +0000 Received: from mail-vk0-f72.google.com (mail-vk0-f72.google.com [209.85.213.72]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id CE727469 for ; Wed, 22 Aug 2018 16:28:08 +0000 (UTC) Received: by mail-vk0-f72.google.com with SMTP id w73-v6so916036vkd.9 for ; Wed, 22 Aug 2018 09:28:08 -0700 (PDT) X-Gm-Message-State: APzg51BSyycyfGYKbl1AYxytA2+iKck6wkPn13J5662dfL/2RNe8tTQ8 6myE1UxhPH8AdTcGrDG8UfnI25nFCD8HC33WWg/hLnzPHyW6LC0InUgJH2Df6O/trV6uOz2YVMc kKxrHujzAbB2Y5Vif9KlVDGTXLY7UrDyq3tlqirNpzb43eLJXUVCLer0= X-Received: by 2002:a1f:39c2:: with SMTP id g185-v6mr1129301vka.165.1534955287986; Wed, 22 Aug 2018 09:28:07 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbMlLOwIfT2clO68VhM9golViOP4XzmTj0tUaVpTPbP4xiQiIQWF3SY6imczgT9p3KMZU6AoHNSxcG/SNBWqC0= X-Received: by 2002:a1f:39c2:: with SMTP id g185-v6mr1129296vka.165.1534955287859; Wed, 22 Aug 2018 09:28:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:e18a:0:0:0:0:0 with HTTP; Wed, 22 Aug 2018 09:28:07 -0700 (PDT) In-Reply-To: References: From: Kirk Lund Date: Wed, 22 Aug 2018 09:28:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: spotless fails Apache license header? To: geode Content-Type: multipart/alternative; boundary="000000000000adf2e3057408a0da" --000000000000adf2e3057408a0da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry to waste everyone=E2=80=99s time with something so trivial. I tried h= ard to ensure my instructions for Setting Up IntelliJ were correct and error-free, so this formatter issue was a big disappointment to me because of that. The instructions have been updated. On Tue, Aug 21, 2018 at 3:57 PM, Kirk Lund wrote: > Looks like it's a feature: https://github.com/google/google-java-format/ > issues/62 > > Is it too late to down-vote our use of google-java-format? > > On Tue, Aug 21, 2018 at 3:43 PM, Kirk Lund wrote: > >> I suppose I was using that older format of the Apache license header and >> then using spotlessApply 100% before running spotlessCheck which was >> reformatting the license header. So even though I was using the older on= e, >> I never ran into the problem until today. >> >> So maybe nothing changed? >> >> But, I still think it's ridiculous that we have spotless configured to >> disallow a double-space after sentence terminator. >> >> On Tue, Aug 21, 2018 at 3:39 PM, Kirk Lund wrote: >> >>> I know it's not a bug in spotless. I think we now have the settings a >>> bit too strict. >>> >>> As of 2-3 weeks ago, I was able to follow the "Setting up IntelliJ" >>> process that I documented at https://github.com/gemfire/gemfire (search >>> down for "Setting up IntelliJ") without spotless failing. See the >>> format of the Apache license header that's pasted into that readme? It = has >>> the extra spaces, including 2 spaces between sentences. >>> >>> 2-3 weeks ago, this was working fine. Now it fails spotless, so >>> something changed. Maybe the version of spotless that we're using in >>> gradle? Or a gradle spotless plugin version changed? >>> >>> At best, it's laughable that our spotless format now complains about >>> correct English syntax in comments and javadocs. At worst, it's evidenc= e >>> that our use of spotless is... "a bit too strict" which in my opinion >>> should be fixed. >>> >>> Can you please look into what changed? I haven't had much luck finding >>> it yet but I assure you that something did change. >>> >>> On Tue, Aug 21, 2018 at 2:26 PM, Patrick Rhomberg >>> wrote: >>> >>>> The only addition with respect to spotless on the 10th was to add the >>>> `devBuild` target (which runs `spotlessApply`) and to require that >>>> `spotlessApply` would run before `compileJava`, if both were to run in= a >>>> given build command. >>>> >>>> Looking at the PR against which these failed, it looks like it might b= e >>>> some disagreement between your IDE's desired format and spotless's. >>>> Notably, the new test file header is thinner and has more space >>>> padding. I >>>> hadn't thought spotless cared about comment blocks, but looking now, i= t >>>> does look like we're consistent everywhere else (within the Java code >>>> that >>>> spotless targets) on how that header is formatted. >>>> >>>> So, you know... It's a feature, not a bug? And we should investigate >>>> the >>>> discrepancies between the format files in /etc, that is, the >>>> Eclipse >>>> file spotless uses and the IntelliJ file that is meant to emulate it. >>>> >>>> On Tue, Aug 21, 2018 at 9:48 AM, Kirk Lund wrote: >>>> >>>> > This appears to be caused by changes made to the build around August >>>> 10? >>>> > >>>> > On Tue, Aug 21, 2018 at 9:38 AM, Kirk Lund wrote: >>>> > >>>> > > Why is spotless now complaining about correct English? By correct >>>> > English, >>>> > > I mean having 2 spaces between sentences in javadoc or comments (i= n >>>> this >>>> > > case it's the Apache license header): >>>> > > >>>> > > -=C2=B7*=C2=B7the=C2=B7License.=C2=B7=C2=B7You=C2=B7may=C2=B7obtai= n=C2=B7a=C2=B7copy=C2=B7of=C2=B7the=C2=B7License=C2=B7at >>>> > > +=C2=B7*=C2=B7the=C2=B7License.=C2=B7You=C2=B7may=C2=B7obtain=C2= =B7a=C2=B7copy=C2=B7of=C2=B7the=C2=B7License=C2=B7at >>>> > > >>>> > > Execution failed for task ':geode-core:spotlessJava'. >>>> > > >>> > >>>> > > > The following files had format violations: >>>> > > >>> > >>>> > > geode-core/src/main/java/org/apache/geode/internal/cache/ >>>> > RegionNameValidation.java >>>> > > >>> > >>>> > > @@ -1,12 +1,12 @@ >>>> > > >>> > >>>> > > /* >>>> > > >>> > >>>> > > =C2=B7*=C2=B7Licensed=C2=B7to=C2=B7the=C2=B7Apache=C2= =B7Software=C2=B7Foundation=C2=B7(ASF)=C2=B7 >>>> > under=C2=B7one=C2=B7or=C2=B7more >>>> > > >>> > >>>> > > -=C2=B7*=C2=B7contributor=C2=B7license=C2=B7agreements.= =C2=B7=C2=B7See=C2=B7the=C2=B7NOTICE=C2=B7 >>>> > file=C2=B7distributed=C2=B7with >>>> > > >>> > >>>> > > +=C2=B7*=C2=B7contributor=C2=B7license=C2=B7agreements.= =C2=B7See=C2=B7the=C2=B7NOTICE=C2=B7 >>>> > file=C2=B7distributed=C2=B7with >>>> > > >>> > >>>> > > =C2=B7*=C2=B7this=C2=B7work=C2=B7for=C2=B7additional=C2= =B7information=C2=B7regarding=C2=B7 >>>> > copyright=C2=B7ownership. >>>> > > >>> > >>>> > > =C2=B7*=C2=B7The=C2=B7ASF=C2=B7licenses=C2=B7this=C2=B7= file=C2=B7to=C2=B7You=C2=B7under=C2=B7the=C2=B7Apache=C2=B7 >>>> > License,=C2=B7Version=C2=B72.0 >>>> > > >>> > >>>> > > =C2=B7*=C2=B7(the=C2=B7"License");=C2=B7you=C2=B7may=C2= =B7not=C2=B7use=C2=B7this=C2=B7file=C2=B7except=C2=B7in=C2=B7 >>>> > compliance=C2=B7with >>>> > > >>> > >>>> > > -=C2=B7*=C2=B7the=C2=B7License.=C2=B7=C2=B7You=C2=B7may= =C2=B7obtain=C2=B7a=C2=B7copy=C2=B7of=C2=B7the=C2=B7License=C2=B7at >>>> > > >>> > >>>> > > +=C2=B7*=C2=B7the=C2=B7License.=C2=B7You=C2=B7may=C2=B7o= btain=C2=B7a=C2=B7copy=C2=B7of=C2=B7the=C2=B7License=C2=B7at >>>> > > >>> > >>>> > > =C2=B7* >>>> > > >>> > >>>> > > -=C2=B7*=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7http://www.a= pache.org/licenses/LICENSE-2.0 >>>> > > >>> > >>>> > > +=C2=B7*=C2=B7http://www.apache.org/licenses/LICENSE-2.0 >>>> > > >>> > >>>> > > =C2=B7* >>>> > > >>> > >>>> > > =C2=B7*=C2=B7Unless=C2=B7required=C2=B7by=C2=B7applicab= le=C2=B7law=C2=B7or=C2=B7agreed=C2=B7to=C2=B7 >>>> > in=C2=B7writing,=C2=B7software >>>> > > >>> > >>>> > > =C2=B7*=C2=B7distributed=C2=B7under=C2=B7the=C2=B7Licen= se=C2=B7is=C2=B7distributed=C2=B7on=C2=B7an=C2=B7" >>>> > AS=C2=B7IS"=C2=B7BASIS, >>>> > > >>>> > > >>>> > > >>>> > >>>> >>> >>> >> > --000000000000adf2e3057408a0da--