geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@apache.org>
Subject Re: no test category, rename tests?
Date Tue, 21 Aug 2018 17:11:08 GMT
+1 Yes! This naming scheme matches what we already have on the Apache Geode
Wiki [1] for naming tests.

Side note: Looks like we need to update the pages on the Wiki to match our
recent changes involving JUnit categories.

[1] https://cwiki.apache.org/confluence/display/GEODE/Writing+tests

On Tue, Aug 21, 2018 at 9:52 AM, Sai Boorlagadda <sai_boorlagadda@apache.org
> wrote:

> Many tests file names are *JUnitTest.java[1] even though it is an
> integration test or distributed test. After we segregated into respective
> folders and removed the test category it is not visible which test it is
> unless we look back into the path of the source directory (integrationTest
> or distributedTest).
>
> So I wanted to rename tests to reflect test category. Let me know if there
> is okay and if I do rename are there any downstream impacts (eg: metrics,
> auto diagnosis etc)
>
> Any integration test will be renamed as *IntegrationTest.java
> Any distributed test will be renamed as *DistributedTest.java
> Any unit test will be renamed as *Test.java.
>
> [1]
> https://github.com/apache/geode/blob/develop/geode-core/
> src/integrationTest/java/org/apache/geode/internal/cache/
> ComplexDiskRegionJUnitTest.java
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message