geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Re: [geode-dev] Gfsh Start Server option "disable-exit-when-out-of-memory"
Date Wed, 08 Aug 2018 17:02:23 GMT
You can go ahead and improve the help text immediately

On Wed, Aug 8, 2018 at 10:00 AM Kenneth Howe <khowe@pivotal.io> wrote:

> +1 to deprecating the existing option and removing it in 2.0. The default
> then will be to retain the addition of the appropriate -X JVM argument
> unless/until we choose to implement Kirk’s first suggestion.
>
> > On Aug 8, 2018, at 9:53 AM, Kirk Lund <klund@apache.org> wrote:
> >
> > We might want to:
> >
> > 1) introduce disable-default-jvm-arguments and implement it to ensure
> that
> > GFSH is not adding any -X args when this option is enabled
> >
> > 2) deprecate disable-exit-when-out-of-memory and then remove it in 2.0
> >
> > On Tue, Aug 7, 2018 at 3:59 PM, Helena Bales <hbales@pivotal.io> wrote:
> >
> >> Hello Geode devs,
> >>
> >> There is an option on the start server Gfsh command that, according to
> the
> >> help message "Prevents the JVM from exiting when an OutOfMemoryError
> >> occurs. When this option is *not* set, a JVM argument gets added,
> depending
> >> on which JVM you are using, to kill the JVM when an OutOfMemoryError
> >> occurs. While setting the option does prevent those arguments from being
> >> set, it does not keep the JVM alive after an OutOfMemoryError occurs.
> >>
> >> Since this option does not do what its help message or name promises, I
> >> would like to propose that we either remove it or rename it to make its
> >> name more closely match its behaviour.
> >>
> >> ~Helena Bales
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message