geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Barrett <jbarr...@pivotal.io>
Subject Re: Revert recent Gradle upgrade
Date Thu, 21 Jun 2018 20:42:06 GMT
I am suffering quite the opposite with 8.4 and seeing much longer build times and rebuilds
on things that have not changed. 

> On Jun 21, 2018, at 12:47 PM, Jens Deppe <jdeppe@pivotal.io> wrote:
> 
> I have a fix which I think will resolve the current problems:
> https://github.com/apache/geode/pull/2074 (currently running precheckin).
> 
> It does require deferring IntelliJ's build to gradle (which may slow some
> tasks down a bit) but will at least let you continue to work.
> 
> The perceived slowdown should be mitigated to a large part by Gradle 4.8's
> ability to cache build results.
> 
> I'd encourage you to grab the diff and see if it helps.
> 
> --Jens
> 
>> On Thu, Jun 21, 2018 at 12:19 PM, Kirk Lund <klund@apache.org> wrote:
>> 
>> I think we should revert the recent Gradle upgrade. This change apparently
>> causes IntelliJ to not be able to build Geode which prevents us from
>> running any Tests in the IDE.
>> 
>> I'd prefer to fix how IntelliJ works with our project but we cannot be
>> without the ability to debug tests. I don't know enough to fix this
>> problem.
>> 
>> If we can't fix the ability to run Tests in the IDE, then we should revert
>> this commit:
>> 
>> commit 7685375ea7229ad0e0fc9ea188cccfa56ff7d8ef
>> Author: Robert Houghton <32176082+rhoughton-pivot@users.noreply.github.com
>>> 
>> Date:   Tue Jun 19 08:28:51 2018 -0700
>> 
>>    GEODE-4791: Enable gradle 4.8 for features and futureproofing (#2050)
>> 
>>    Enable:
>>    * Java 10 (when ready)
>>    * remove deprecated configuration settings
>>    * build-cache
>>    * incremental
>>    * Update classpath/srcpath logic
>> 
>>    Disable:
>>    * parallel (to fix Tomcat tests bind issues)
>> 
>>    Signed-off-by: Robert Houghton <rhoughton@pivotal.io>
>>    Signed-off-by: Jens Deppe <jdeppe@pivotal.io>
>>    Signed-off-by: Robert Houghton <rhoughton@pivotal.io>
>>    Signed-off-by: Jens Deppe <jdeppe@pivotal.io>
>> 

Mime
View raw message