geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sai Boorlagadda <sai.boorlaga...@gmail.com>
Subject Re: [Discussion] Improving Spotless to be Even More Beautiful
Date Mon, 19 Mar 2018 23:17:37 GMT
+1

On Mon, Mar 19, 2018 at 4:03 PM, Kirk Lund <klund@apache.org> wrote:

> +1
>
> On Mon, Mar 19, 2018 at 2:51 PM, Patrick Rhomberg <prhomberg@pivotal.io>
> wrote:
>
> > Hello all!
> >
> >  I'm making another pass at patching up some of our smellier broken
> > windows, to mix metaphors.  To that end, there are a few things I'd like
> to
> > add to spotless to more closely enforce adherence to our own style guide.
> >
> > I'd like to do the following to our spotless:
> > - Bump spotless to the newest version, enabling some of the features
> below
> > - Have spotless only run spotless on files that have changed (Yay,
> slightly
> > faster builds!)
> > - Have spotless perform the following spotless tasks:
> > --- Remove unused imports.
> > --- Prohibit wildcard imports, which may require manual expansion by the
> > developer.  (But, in fairness, you shouldn't be using wildcard imports
> > anyway.)
> > --- Remove trivial javadoc stubs that are implicit in the method
> signature
> > (e.g., "@param p" with no description of what p actually is).
> > --- Remove empty javadocs and block comments.
> >
> > This will again touch a great many files, so it should be targeted for
> > immediately following a release, perhaps the impending 1.5.  It can
> pretty
> > easily be exploded into several commits across each subproject and task
> for
> > ease of review.
> >
> > Thoughts?
> >
> > Imagination is Change.
> > ~Patrick Rhomberg
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message