geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Barrett <jbarr...@pivotal.io>
Subject Re: Has github changed some preferences?
Date Thu, 07 Dec 2017 03:09:21 GMT
Yes, something changed on GH very recently. My previous PR a few days ago was correct by default.
Today I had to explicitly select develop branch. 

> On Dec 6, 2017, at 3:57 PM, Dave Barnes <dbarnes@pivotal.io> wrote:
> 
> I was bitten by that earlier this afternoon. Instead of 2 files modified in
> 1 commit, I had 5,000 commits!
> 
>> On Wed, Dec 6, 2017 at 3:52 PM, Jens Deppe <jensdeppe@apache.org> wrote:
>> 
>> It seems that (at least my github pages) are acting a bit differently.
>> 
>> When creating a Pull Request make sure that you create it against
>> *develop* and not *master*:
>> 
>> [image: Inline image 1]
>> 
>> I would typically just ignore this and click through but that led me to
>> creating a PR with 100s of changes.
>> 
>> I'll be double-checking for the next PR...
>> 
>> --Jens
>> 

Mime
View raw message