geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@apache.org>
Subject Re: CommandOverHttpDUnitTest seems to be causing a bunch of tests to needlessly be run
Date Mon, 27 Nov 2017 17:39:35 GMT
CommandOverHttpDUnitTest reruns those tests with the system
property CliCommandTestBase.USE_HTTP_SYSTEM_PROPERTY enabled.

Using a suite results in the results of these tests being overwritten when
the tests rerun using HTTP.

An approach that would keep both test results would be to subclass each
test with CliCommandTestBase.USE_HTTP_SYSTEM_PROPERTY enabled. This would
also be more obvious to other developers that aren't has familiar with
these tests. The subclasses would have a different test name and thus not
overwrite the non-HTTP results: DiskStoreCommandsOverHttpDUnitTest,
GemfireDataCommandsOverHttpDUnitTest,
ListAndDescribeDiskStoreCommandsOverHttpDUnitTest,
QueueCommandsOverHttpDUnitTest, ShellCommandsOverHttpDUnitTest,
ShowStackTraceOverHttpDUnitTest.

On Mon, Nov 20, 2017 at 6:36 PM, Jinmei Liao <jiliao@pivotal.io> wrote:

> We are trying to get rid of this suite, currently there are only 5 test
> classes included in that suite now. This suites runs those tests in a
> different connect type. But we are trying to refactor them all to not to
> use a suite.
>
> On Mon, Nov 20, 2017 at 3:19 PM, Bruce Schuchardt <bschuchardt@pivotal.io>
> wrote:
>
> > This is a test-suite class that is causing 13 other test classes to be
> run
> > a second time.  We should remove this class and create a gradle task to
> run
> > the tests based on their category, like we do with client/server,
> > membership and other categories.
> >
> >
>
>
> --
> Cheers
>
> Jinmei
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message