geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Smith <dsm...@pivotal.io>
Subject Re: [DISCUSS] changes to registerInterest API
Date Fri, 17 Nov 2017 01:19:54 GMT
I don't really like the regex option - it implies that your keys are all
strings. Will any other regular expressions work on non string objects?
registerInterestAllKeys() seems like a better option.

-Dan

On Thu, Nov 16, 2017 at 4:34 PM, Michael Stolz <mstolz@pivotal.io> wrote:

> I don't like the vararg option.
> If i'm maintaining a list of keys i'm interested in, I want to be able to
> pass that List in.
> Varargs is a poor substitute. It might even cause problems of pushing in
> multiple different types. Keys must all be of one type for a given Region.
>
>
> I'm very much in favor of deprecating the ALL_KEYS string in favor of
> something that is typed specially if you refer to ALL_KEYS.
>
>
> If that works, then we don't necessarily need the additional API
> registerInterestAllKeys(). But if ALL_KEYS can't be a special type to get
> over the compilation issues then we should go with the new API.
>
>
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Lead
> Mobile: +1-631-835-4771
>
> On Thu, Nov 16, 2017 at 7:02 PM, Anilkumar Gingade <agingade@pivotal.io>
> wrote:
>
> > +1 Deprecating ALL_KEYS option; I believe this is added before we
> supported
> > regex support.
> >
> >  Doesn't seems like a new API is needed. The regex java doc clearly
> > specifies the effect of ".*".
> >
> > +1 for deprecating list argument; and replacing with new API.
> >
> > -Anil.
> >
> >
> >
> > On Thu, Nov 16, 2017 at 3:36 PM, Jason Huynh <jhuynh@pivotal.io> wrote:
> >
> > > For GEODE-3813 <https://issues.apache.org/jira/browse/GEODE-3813>:
> > Region
> > > registerInterest API usage of type parameters is broken
> > > <https://issues.apache.org/jira/browse/GEODE-3813>
> > >
> > >
> > > The current API to registerInterest allows a special string token
> > > “ALL_KEYS” to be passed in as the parameter to registerInterest(T key).
> > > This special token causes the registerInterest to behave similar to
> > > registerInterestRegex(“.*”).  As the ticket states, if the region has
> > been
> > > typed to anything other than Object or String, the usage of “ALL_KEYS”
> > as a
> > > parameter results in a compilation error.
> > >
> > >
> > > Proposals:
> > >
> > > I would like to deprecate the special string “ALL_KEYS” and document a
> > > workaround of using registerInterestRegex(“.*”) or we can add a new API
> > > called registerInterestAllKeys()
> > >
> > >
> > > I think we should also deprecate passing a List Object of keys into
> > > registerInterest.  It has the same compilation restrictions as
> “ALL_KEYS”
> > > when the region is key constrained/typed.  The reason why List would be
> > > used is to allow registering multiple keys at once.  Instead, we can
> add
> > a
> > > new var arg API like registerInterest(T… keys).  This problem and
> > solution
> > > was also documented in the ticket by the ticket creator (Kirk Lund)
> > >
> > >
> > >
> > > Thanks,
> > >
> > > -Jason
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message