geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anthony Baker <aba...@pivotal.io>
Subject Re: [DISCUSS] FunctionAdapter incompatible serialVersionUID
Date Tue, 28 Nov 2017 20:40:42 GMT
I think we should wait for a major release to remove API’s.  If we broke a public API, we
should fix that IMO.

Anthony


> On Nov 28, 2017, at 11:40 AM, Patrick Rhomberg <prhomberg@pivotal.io> wrote:
> 
> +1 to removing a long-deprecated class from the Geode side.
> 
> On Tue, Nov 28, 2017 at 8:04 AM, Bruce Schuchardt <bschuchardt@pivotal.io>
> wrote:
> 
>> How about just getting rid of this class?  After all it was marked as
>> being deprecated in 1.0.  Pivotal could add a compatible FunctionAdapter
>> class in their GemFire builds to support these old clients.
>> 
>> 
>> 
>> On 11/27/17 10:18 AM, Jason Huynh wrote:
>> 
>>> This is a discussion for the fix to GEODE-4008:
>>> InvalidClassException when deserializing FunctionAdapter from pre Geode
>>> clients
>>> 
>>> There was a change to deprecate FunctionAdapter in Geode (before 1.0), and
>>> this also removed the method signatures in the class. This caused Java to
>>> generate a new serialVersionUID to the class because one was not assigned
>>> previously. However we have clients pre Geode that when they attempt to
>>> execute a function by serializing the function across (not using a
>>> function
>>> id), the FunctionAdapter class is unable to deserialize properly.
>>> 
>>> The proposed fix is to assign a serialVersionUID to the class that matches
>>> that of the pre Geode FunctionAdapter. This will cause any Geode 1.0-1.3
>>> clients to now run into the error but the older clients would work fine.
>>> Because FunctionAdapter has been deprecated it should be easy enough for
>>> Geode 1.0-1.3 users to change their custom classes to implement Function
>>> directly and not use the deprecated FunctionAdapter class.
>>> 
>>> Please let me know if there is a better solution or if there are problems
>>> with the proposed fix.
>>> 
>>> 
>>> Thanks,
>>> 
>>> -Jason
>>> 
>>> 
>> 


Mime
View raw message