Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
MIME-Version: 1.0
In-Reply-To: <6e04e050-ea4f-f916-2f17-df940cc16e98@pivotal.io>
References: <20170906000903.63444.51098@reviews-vm2.apache.org>
 <20170906154722.26227.13231@reviews-vm2.apache.org> <CANZ+UhNKwygPpUBEk_kQ887j04c-DabX-96UEZJjFCR1nNVDiA@mail.gmail.com>
 <6e04e050-ea4f-f916-2f17-df940cc16e98@pivotal.io>
From: Brian Baynes <bbaynes@pivotal.io>
Date: Wed, 6 Sep 2017 12:43:55 -0700
Message-ID: <CANZ+UhPMSAUnNhpJftPXT-061kZ9iM7EJuUBmz=6TjYMvay+Rg@mail.gmail.com>
Subject: Re: Review Request 62088: GEODE-3249 Validate internal client/server messages
To: Bruce Schuchardt <bschuchardt@pivotal.io>
Cc: dev@geode.apache.org
Content-Type: multipart/alternative; boundary="94eb2c1cdef07a4a1205588a9089"
archived-at: Wed, 06 Sep 2017 19:44:03 -0000

--94eb2c1cdef07a4a1205588a9089
Content-Type: text/plain; charset="UTF-8"

Ah, I see. Makes sense.

On Sep 6, 2017 12:23 PM, "Bruce Schuchardt" <bschuchardt@pivotal.io> wrote:

I think we will want to remove this property in the next major release and
have the behavior it enables be how the servers always act.

On 9/6/17 10:23 AM, Brian Baynes wrote:

In this case, won't we be changing the default of this property with the
next major release?  So perhaps the choice is to follow the default=false
convention now, or with the next major release..?


On Wed, Sep 6, 2017 at 8:47 AM, Bruce Schuchardt <bschuchardt@pivotal.io>
wrote:

>
>
> > On Sept. 5, 2017, 5:09 p.m., Galen O'Sullivan wrote:
> > > I prefer config option names to be as unambiguous as possible. I think
> `allow` would be clearer than `disallow` because it avoids
> double-negatives. Can we use
> > > `allow-internal-messages-without-credentials` and have it default to
> `true`?
>
> In general Java properties ought to default to _false_ if they aren't
> set.  We've had other properties default to _true_ in the past and they
> were awkward.
>
>
> - Bruce
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62088/#review184608
> -----------------------------------------------------------
>
>
> On Sept. 5, 2017, 10:57 a.m., Bruce Schuchardt wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/62088/
> > -----------------------------------------------------------
> >
> > (Updated Sept. 5, 2017, 10:57 a.m.)
> >
> >
> > Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh
> Khamesra, and Udo Kohlmeyer.
> >
> >
> > Bugs: GEODE-3249
> >     https://issues.apache.org/jira/browse/GEODE-3249
> >
> >
> > Repository: geode
> >
> >
> > Description
> > -------
> >
> > This change leaves the security hole in place but allows you to plug it
> by setting the system property
> >
> > geode.disallow-internal-messages-without-credentials=true
> >
> > Clients must be upgraded to the release containing this change if you
> set this system property to true and client/server authentication is
> enabled.  Otherwise client messages to register PDX types or Instantiators
> will be rejected by the servers.
> >
> >
> > Diffs
> > -----
> >
> >   geode-core/src/main/java/org/apache/geode/internal/cache/ti
> er/sockets/ServerConnection.java b243d8ebb8f7fb698a4637c7a787ee2d7216f1f7
> >
> >
> > Diff: https://reviews.apache.org/r/62088/diff/1/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Bruce Schuchardt
> >
> >
>
>

--94eb2c1cdef07a4a1205588a9089--