Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============2128977494780123611=="
MIME-Version: 1.0
Subject: Re: Review Request 62506: GEODE-3679: Original client member Id in the
 transaction should be set in the PartitionMessage
From: Eric Shu <eshu@pivotal.io>
To: anilkumar gingade <agingade@pivotal.io>, Nick Reich <nreich@pivotal.io>,
 Lynn Gallinat <lgallinat@pivotal.io>, Darrel Schneider <dschneider@pivotal.io>,
 Kirk Lund <kirk.lund@gmail.com>
Cc: geode <dev@geode.apache.org>, Eric Shu <eshu@pivotal.io>
Date: Fri, 22 Sep 2017 19:12:46 -0000
Message-ID: <20170922191246.9074.39472@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Eric Shu <noreply@reviews.apache.org>
References: <20170922182711.9074.15509@reviews-vm2.apache.org>
In-Reply-To: <20170922182711.9074.15509@reviews-vm2.apache.org>
Reply-To: Eric Shu <eshu@pivotal.io>
archived-at: Fri, 22 Sep 2017 19:12:52 -0000

--===============2128977494780123611==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 22, 2017, 6:27 p.m., Nick Reich wrote:
> > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
> > Lines 4109 (patched)
> > <https://reviews.apache.org/r/62506/diff/1/?file=1832888#file1832888line4109>
> >
> >     This is actually "doTransactionOnServer", as there is nothing about the method which is tied to server1.

client is connect to server1, tx should be on server1.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62506/#review186003
-----------------------------------------------------------


On Sept. 22, 2017, 7:12 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62506/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2017, 7:12 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3679
>     https://issues.apache.org/jira/browse/GEODE-3679
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Sets the originating member id from client transaction in partition message when a server needs to perform operaton and send to other peers.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java 8c27107 
>   geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java 96b89b9 
> 
> 
> Diff: https://reviews.apache.org/r/62506/diff/2/
> 
> 
> Testing
> -------
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


--===============2128977494780123611==--