Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 87969200CFD for ; Wed, 6 Sep 2017 20:48:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 86160160BE4; Wed, 6 Sep 2017 18:48:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CCFD11609C0 for ; Wed, 6 Sep 2017 20:48:27 +0200 (CEST) Received: (qmail 81835 invoked by uid 500); 6 Sep 2017 18:48:26 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 81815 invoked by uid 99); 6 Sep 2017 18:48:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Sep 2017 18:48:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 447D4CCEEC; Wed, 6 Sep 2017 18:48:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VIn9M2uR6PtK; Wed, 6 Sep 2017 18:48:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7B6315FB9F; Wed, 6 Sep 2017 18:48:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 19976E00C9; Wed, 6 Sep 2017 18:48:20 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 03CE0C41A2B; Wed, 6 Sep 2017 18:48:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9176997369776133614==" MIME-Version: 1.0 Subject: Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue From: Nick Reich To: anilkumar gingade , Nick Reich , Lynn Gallinat , Darrel Schneider Cc: geode , Eric Shu Date: Wed, 06 Sep 2017 18:48:20 -0000 Message-ID: <20170906184820.26308.35272@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Nick Reich X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61895/ X-Sender: Nick Reich X-ReviewBoard-ShipIt: 1 References: <20170906184221.26227.40740@reviews-vm2.apache.org> In-Reply-To: <20170906184221.26227.40740@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Nick Reich X-ReviewRequest-Repository: geode archived-at: Wed, 06 Sep 2017 18:48:28 -0000 --===============9176997369776133614== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61895/#review184710 ----------------------------------------------------------- Ship it! Ship It! - Nick Reich On Sept. 6, 2017, 6:42 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61895/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 6:42 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich. > > > Bugs: GEODE-3516 > https://issues.apache.org/jira/browse/GEODE-3516 > > > Repository: geode > > > Description > ------- > > Remove the thread from waiting thread queue after successfully resumed the transaction > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java a0a4d7c > geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java a2c1e70 > > > Diff: https://reviews.apache.org/r/61895/diff/3/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > > --===============9176997369776133614==--