geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ernest Burghardt <eburgha...@pivotal.io>
Subject Re: [Vote] virtual void fromData(PdxReaderPtr input) to virtual void fromData(const PdxReaderPtr input);
Date Fri, 15 Sep 2017 17:53:02 GMT
+1 for const PdxReader


- remember, vote early and vote often...

On Fri, Sep 15, 2017 at 11:40 AM, Mark Hanson <mhanson@pivotal.io> wrote:

> Note the const on PdxReaderPtr virtual void fromData(const PdxReaderPtr
> input);
>
> Hi All,
>
> So there is a question outstanding about whether or not we want to add
> const to PdxReaderPtr for fromData calls. It seems reasonable and plausible.
>
> Proposal: Change to virtual void fromData(const PdxReaderPtr input) from
> virtual void fromData(PdxReaderPtr input)
>
> Get your +1’s and -1’s in to vote.
>
> Thanks,
> Mark

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message