geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael William Dodge <mdo...@pivotal.io>
Subject Re: [Vote] Better type checking by moving PdxWrapper from a standard class to a template class.
Date Thu, 21 Sep 2017 17:24:47 GMT
+1 for type safety

Sarge

> On 21 Sep, 2017, at 10:21, Mark Hanson <mhanson@pivotal.io> wrote:
> 
> Here is a link to my branch in my fork that has the changes on it.
> 
> https://github.com/mhansonp/geode-native/tree/wip/templatePdxWrapper
> 
> Thanks,
> Mark
> 
> On Thu, Sep 21, 2017 at 10:19 AM, Mark Hanson <mhanson@pivotal.io> wrote:
> 
>> Hi All,
>> 
>> In reviewing the PdxWrapper class it, it seemed like it would be a good
>> move to make this a template class. This will allow better type checking
>> anytime we use it.
>> 
>> An example of what is being planned is to change from
>> 
>> MyClass object;
>> PdxWrapper((void *) object,...)
>> to PdxWrapper<MyClass>(object, ....)
>> 
>> I have a chunk of code moved over that seems to show it is possible,
>> though there are some bugs that need to be addressed, so it is not a done
>> deal.
>> 
>> What do people think?
>> 
>> Thanks,
>> Mark
>> 


Mime
View raw message