geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule
Date Fri, 08 Sep 2017 15:51:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62179/
-----------------------------------------------------------

(Updated Sept. 8, 2017, 3:51 p.m.)


Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Changes
-------

reworked stopVM in the rule to consider the client VM case. Get rid of the for loop for streaming.


Repository: geode


Description
-------

Test Rule Fix: clean up clientVM if using LocatorServerStartUpRule to get the ClientVM


Diffs (updated)
-----

  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsShareConfigurationDUnitTest.java
1a5fc3485e159ca311247e617d5bec2b37c6ee10 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoresDUnitTest.java
3e9227e99ad57624b024498d0ff5e807c8853221 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java
31c58177d60c9cf9ad0d07fc7a7daf8b332d3c9e 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
f0385e21f708d9a085e7129d82fb3101e2fb8322 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java a832a2590527100afc05fb9de2e332a263d52c19

  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java b35270e2d97930cee68d8c54221a04c20dfb96de

  geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationIndexWithFromClauseDUnitTest.java
c301d587c04651a03170e3da6451ebf2acf063c0 


Diff: https://reviews.apache.org/r/62179/diff/2/

Changes: https://reviews.apache.org/r/62179/diff/1-2/


Testing
-------

precheckin running


Thanks,

Jinmei Liao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message