geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Reich <nre...@pivotal.io>
Subject Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats
Date Thu, 07 Sep 2017 20:08:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62164/#review184872
-----------------------------------------------------------




geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 17 (patched)
<https://reviews.apache.org/r/62164/#comment261066>

    I think this is the wrong library, or are you using assertj on purpose instead of junit?



geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 128 (patched)
<https://reviews.apache.org/r/62164/#comment261065>

    This could be cleaned up by getting the region once at the top of the method and using
that variable throughout.



geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 129 (patched)
<https://reviews.apache.org/r/62164/#comment261069>

    This method seems to be doing two distinct things: the first is a vm specific check of
region entry and bucket count sizes (which could be its own method that takes only a single
vm) and the second is checking overflow, which could also be its own method (especially since
only one region is checked).



geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 156 (patched)
<https://reviews.apache.org/r/62164/#comment261070>

    Normalize variable names to camel case?



geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
Lines 249 (patched)
<https://reviews.apache.org/r/62164/#comment261067>

    use TEST_REGION constant


- Nick Reich


On Sept. 7, 2017, 4:56 p.m., Lynn Gallinat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62164/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 4:56 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and Nick Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> We now update the stats in a member that lost a bucket due to rebalancing
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 465a3dd

>   geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62164/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin
> 
> 
> Thanks,
> 
> Lynn Gallinat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message